Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dune >= 1.7 incompatible with OCaml 4.12 #16856

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

kit-ty-kate
Copy link
Member

Should be fixed in the next major release most probably ocaml/dune#3585

I suggest to merge this PR at the same time as the next release with a fix so that users won't have to rebuild their whole switch for nothing. cc @rgrinberg are there any release planned soon?

@camelus
Copy link
Contributor

camelus commented Jul 22, 2020

Commit: 39b993f

Good to see you Madam.

☀️ All lint checks passed 39b993f
  • These packages passed lint tests: dune.1.11.0, dune.1.11.1, dune.1.11.2, dune.1.11.3, dune.1.11.4, dune.2.0.0, dune.2.0.1, dune.2.1.1, dune.2.1.2, dune.2.1.3, dune.2.2.0, dune.2.3.0, dune.2.3.1, dune.2.4.0, dune.2.5.0, dune.2.5.1, dune.2.6.0, dune.2.6.1

☀️ Installability check (+0)

@rgrinberg
Copy link
Member

are there any release planned soon?

We could make a point release with that fix if you'd like

@kit-ty-kate
Copy link
Member Author

We could make a point release with that fix if you'd like

If you can that'd be amazing. I'm sure @ejgallego and other dev testers would be very happy.

@avsm
Copy link
Member

avsm commented Jul 26, 2020

I don't think adding an upper bound will cause a package recompile -- that's only if the archive or build/install instructions change. It would be good to get this in to make opam-repository more consistent as soon as possible @kit-ty-kate, and merge the dune point release subsequently

@kit-ty-kate
Copy link
Member Author

I don't think adding an upper bound will cause a package recompile

Sadly it does. I tested it with opam 2.0.7 before saying that

@kit-ty-kate kit-ty-kate marked this pull request as ready for review July 28, 2020 00:49
@kit-ty-kate kit-ty-kate merged commit 4297a14 into ocaml:master Jul 28, 2020
@kit-ty-kate kit-ty-kate deleted the 412-fixes branch July 28, 2020 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants