[ocaml] [ci] Travis testing and compat for OCaml 4.12 #3585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejgallego
force-pushed
the
ocaml+412
branch
2 times, most recently
from
f43feb9 to
5a67841
Compare
emillon
approved these changes
Jun 29, 2020
ejgallego
force-pushed
the
ocaml+412
branch
3 times, most recently
from
65be23f to
fce6474
Compare
OCaml 4.12 has introduced a new field in the `Gc.stats` record, `forced_major_collections`. This makes compilation of Dune fail due to `src/catapult/catapult.ml:fake_gc_stat` We call `Gc.quick_stats` and override the set of safe fields. Fixes: ocaml#3583 cc: ocaml#2298 Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
We may want to have some of these tests `allow_failure`. Fixes ocaml#2298 Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
ejgallego
changed the title
ejgallego
added a commit
to ejgallego/coq
that referenced
this pull request
Jun 30, 2020
Recent changes in Coqbot plus the unfortunate breakage OCaml upstream has make this too noisy. We will re-enable once ocaml/dune#3585 is accepted upstream.
emillon
reviewed
Jul 1, 2020
| @@ -26,7 +28,7 @@ let fake_gc_stat = | |||
| ; compactions = 0 | |||
| ; top_heap_words = 0 | |||
| ; stack_size = 0 | |||
| } | |||
| } [@ocaml.warning "-23"] (* all fiels of record used *) | |||
There was a problem hiding this comment.
Suggested change
| } [@ocaml.warning "-23"] (* all fiels of record used *) | |
| } [@ocaml.warning "-23"] (* all fields are used in OCaml < 4.12 *) |
fajb
pushed a commit
to fajb/coq
that referenced
this pull request
Jul 9, 2020
Recent changes in Coqbot plus the unfortunate breakage OCaml upstream has make this too noisy. We will re-enable once ocaml/dune#3585 is accepted upstream.
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Jul 26, 2020
…lugin, dune-private-libs and dune-glob (2.6.2) CHANGES: * Fix compatibility with OCaml 4.12 (ocaml/dune#3585, fixes ocaml/dune#3583, @ejgallego)
|
I released 2.6.2 with the fix to 4.12. |
fajb
pushed a commit
to fajb/coq
that referenced
this pull request
Aug 24, 2020
Recent changes in Coqbot plus the unfortunate breakage OCaml upstream has make this too noisy. We will re-enable once ocaml/dune#3585 is accepted upstream.
|
Closing this PR as I'm not familiar with Github actions. We should open a bug for testing vs 4.11 and 4.12 tho. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCaml 4.12 has introduced a new field in the
Gc.statsrecord,forced_major_collections. This makes compilation of Dune fail due tosrc/catapult/catapult.ml:fake_gc_statWe call
Gc.quick_statsand override the set of safe fields.We also add testing of OCaml
trunkand 4.11 to Travis, to prevent further problems. This is a non-trivial change so it needs review.Whether we should place the
trunktest inallow_failureis open.Fixes: #3583, fixes #2298