Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] dune-build-info, dune, dune-configurator, dune-action-plugin, dune-private-libs and dune-glob (2.7.0) #17005

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

rgrinberg
Copy link
Member

Embed build informations inside executable

CHANGES:

@camelus
Copy link
Contributor

camelus commented Aug 14, 2020

Commit: fd24ec4

A pull request by opam-seasoned @rgrinberg.

☀️ All lint checks passed fd24ec4
  • These packages passed lint tests: dune-action-plugin.2.7.0, dune-build-info.2.7.0, dune-configurator.2.7.0, dune-glob.2.7.0, dune-private-libs.2.7.0, dune.2.7.0

☀️ Installability check (+6)
  • new installable packages (6): dune.2.7.0 dune-action-plugin.2.7.0 dune-build-info.2.7.0 dune-configurator.2.7.0 dune-glob.2.7.0 dune-private-libs.2.7.0

@kit-ty-kate
Copy link
Member

I believe ocaml/dune#3585 should've been merged before releasing this version. It seems a bit inconsistent to me if dune 2.6.2 supports OCaml 4.12 but not dune 2.7.0

@kit-ty-kate
Copy link
Member

oh nevermind, the commit has been cherry-picked but the PR is still there for some reason

@avsm
Copy link
Member

avsm commented Aug 14, 2020

@voodoos notes that there is a regression:

Dune now checks that the field name(s) in exectuable(s) stanzas contains only valid module names. (ocaml/dune#3646)
However in https://github.com/garrigue/lablgtk the example folder contains an executable with name dialog-thread in a file named dialog-thread.ml.
The compiler accepts that file but the new dune doesn't.

@voodoos
Copy link
Contributor

voodoos commented Aug 14, 2020

We decided to postpone that new check of the name field of executables stanzas.

…lugin, dune-private-libs and dune-glob (2.7.0)

CHANGES:

- Write intermediate files in a `.mdx` folder for each `mdx` stanza
  to prevent the corresponding actions to be executed as part of the `@all`
  alias (ocaml/dune#3659, @NathanReb)

- Read Coq flags from `env` (ocaml/dune#3547 , fixes ocaml/dune#3486, @gares)

- Add instrumentation framework to toggle instrumentation by `bisect_ppx`,
  `landmarks`, etc, via dune-workspace and/or the command-line. (ocaml/dune#3404, ocaml/dune#3526
  @stephanieyou, @nojb)

- Formatting of dune files is now done in the executing dune process instead of
  in a separate process. (ocaml/dune#3536, @nojb)

- Add a `--debug-artifact-substution` flag to help debug problem with
  version not being captured by `dune-build-info` (ocaml/dune#3589,
  @jeremiedimino)

- Allow the use of the `context_name` variable in the `enabled_if` fields of
  executable(s) and install stanzas. (ocaml/dune#3568, fixes ocaml/dune#3566, @voodoos)

- Fix compatibility with OCaml 4.12.0 when compiling empty archives; no .a file
  is generated. (ocaml/dune#3576, @dra27)

- `$ dune utop` no longer tries to load optional libraries that are unavailable
  (ocaml/dune#3612, fixes ocaml/dune#3188, @anuragsoni)

- Fix dune-build-info on 4.10.0+flambda (ocaml/dune#3599, @emillon, @jeremiedimino).

- Allow multiple libraries with `inline_tests` to be defined in the same
  directory (ocaml/dune#3621, @rgrinberg)

- Run exit hooks in jsoo separate compilation mode (ocaml/dune#3626, fixes ocaml/dune#3622,
  @rgrinberg)

- Add (alias ...), (mode ...) fields to (copy_fields ...) stanza (ocaml/dune#3631, @nojb)

- (copy_files ...) now supports copying files from outside the workspace using
  absolute file names (ocaml/dune#3639, @nojb)

- Dune does not use `ocamlc` as an intermediary to call C compiler anymore.
  Configuration flags `ocamlc_cflags` and `ocamlc_cppflags` are always prepended
  to the compiler arguments. (ocaml/dune#3565, fixes ocaml/dune#3346, @voodoos)

- Revert the build optimization in ocaml/dune#2268. This optimization slows down building
  individual executables when they're part of an `executables` stanza group
  (ocaml/dune#3644, @rgrinberg)

- Use `{dev}` rather than `{pinned}` in the generated `.opam` file. (ocaml/dune#3647,
  @kit-ty-kate)

- Insert correct extension name when editing `dune-project` files. Previously,
  dune would just insert the stanza name. (ocaml/dune#3649, fixes ocaml/dune#3624, @rgrinberg)

- Fix crash when evaluating an `mdx` stanza that depends on unavailable
  packages. (ocaml/dune#3650, @craigfe)

- Fix typo in `cache-check-probablity` field in dune config files. This field
  now requires 2.7 as it wasn't usable before this version. (ocaml/dune#3652, @edwintorok)

- Add `"odoc" {with-doc}` to the dependencies in the generated `.opam` files.
  (ocaml/dune#3667, @kit-ty-kate)

- Do not allow user actions to capture dune's stdin (ocaml/dune#3677, fixes ocaml/dune#3672,
  @rgrinberg)

- `(subdir ...)` stanzas can now appear in dune files used via `(include ...)`.
  (ocaml/dune#3676, @nojb)
@rgrinberg
Copy link
Member Author

I've glanced over the failures, and I don't see anything noteworthy.

@avsm
Copy link
Member

avsm commented Aug 18, 2020

Also lgtm, just waiting for CI run to pass in a few hours

@kit-ty-kate
Copy link
Member

Looks good. Thanks!

@kit-ty-kate kit-ty-kate merged commit a1a8bab into ocaml:master Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment