Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Testing the build with OCaml trunk #2298

Closed
ejgallego opened this issue Jun 19, 2019 · 3 comments · Fixed by #7055
Closed

[ci] Testing the build with OCaml trunk #2298

ejgallego opened this issue Jun 19, 2019 · 3 comments · Fixed by #7055

Comments

@ejgallego
Copy link
Collaborator

As discussed in #2296 it could be interesting to have a [soft, as in allowed to fail] CI job that tries to compile with Dune with OCaml's trunk.

It could be argued that this should be the responsibility of OCaml's CI itself, but for now we can add it here.

This kind of testing is not very stable but in Coq we have found it to be quite useful.
@ejgallego ejgallego mentioned this issue Jun 19, 2019
Merged
@ghost
Copy link

ghost commented Jun 19, 2019

Ideally you want both so that none of the compiler or dune can break each other's CI. In particular, if we had both we could safely make it a hard requirement on both.

Having it in Dune only as a soft failure seems like a good first step indeed.

ejgallego added a commit to ejgallego/dune that referenced this issue Jul 20, 2019
@ejgallego
Fix build with OCaml trunk.
5b4df2a 
Another instance of what is detailed in
ocaml#2342 ; until
ocaml#2298 is fixed I guess we'll have
to live with commits like this.
ejgallego added a commit to ejgallego/dune that referenced this issue Jul 20, 2019
@ejgallego
Fix build with OCaml trunk.
d583f51 
Another instance of what is detailed in
ocaml#2342 ; until
ocaml#2298 is fixed I guess we'll have
to live with commits like this.

Signed-off-by: Emilio Jesus Gallego Arias <e@x80.org>
@ejgallego ejgallego mentioned this issue Jul 20, 2019
Merged
ejgallego added a commit to ejgallego/dune that referenced this issue Jul 21, 2019
@ejgallego
Fix build with OCaml trunk.
752f035 
Another instance of what is detailed in
ocaml#2342 ; until
ocaml#2298 is fixed I guess we'll have
to live with commits like this.

Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
@ejgallego ejgallego mentioned this issue Jun 28, 2020
Closed
ejgallego added a commit to ejgallego/dune that referenced this issue Jun 29, 2020
@ejgallego
[ocaml] Restore compatibility with OCaml 4.12
0b11cc1 
OCaml 4.12 has introduced a new field in the `Gc.stats` record,
`forced_major_collections`. This makes compilation of Dune fail due to
`src/catapult/catapult.ml:fake_gc_stat`

We call `Gc.quick_stats` and override the set of safe fields.

Fixes: ocaml#3583

cc: ocaml#2298
@ejgallego ejgallego mentioned this issue Jun 29, 2020
Closed
ejgallego added a commit to ejgallego/dune that referenced this issue Jun 29, 2020
@ejgallego
[ocaml] Restore compatibility with OCaml 4.12
f43feb9 
OCaml 4.12 has introduced a new field in the `Gc.stats` record,
`forced_major_collections`. This makes compilation of Dune fail due to
`src/catapult/catapult.ml:fake_gc_stat`

We call `Gc.quick_stats` and override the set of safe fields.

Fixes: ocaml#3583

cc: ocaml#2298
ejgallego added a commit to ejgallego/dune that referenced this issue Jun 29, 2020
@ejgallego
[ocaml] Restore compatibility with OCaml 4.12
5a67841 
OCaml 4.12 has introduced a new field in the `Gc.stats` record,
`forced_major_collections`. This makes compilation of Dune fail due to
`src/catapult/catapult.ml:fake_gc_stat`

We call `Gc.quick_stats` and override the set of safe fields.

Fixes: ocaml#3583

cc: ocaml#2298

Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
ejgallego added a commit to ejgallego/dune that referenced this issue Jun 29, 2020
@ejgallego
[ocaml] Restore compatibility with OCaml 4.12
0be8f48 
OCaml 4.12 has introduced a new field in the `Gc.stats` record,
`forced_major_collections`. This makes compilation of Dune fail due to
`src/catapult/catapult.ml:fake_gc_stat`

We call `Gc.quick_stats` and override the set of safe fields.

Fixes: ocaml#3583

cc: ocaml#2298

Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
ejgallego added a commit to ejgallego/dune that referenced this issue Jun 30, 2020
@ejgallego
[ocaml] Restore compatibility with OCaml 4.12
d5ee4b7 
OCaml 4.12 has introduced a new field in the `Gc.stats` record,
`forced_major_collections`. This makes compilation of Dune fail due to
`src/catapult/catapult.ml:fake_gc_stat`

We call `Gc.quick_stats` and override the set of safe fields.

Fixes: ocaml#3583

cc: ocaml#2298

Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
ejgallego added a commit to ejgallego/dune that referenced this issue Jun 30, 2020
@ejgallego
[ci] Test with OCaml trunk / beta
65be23f 
We may want to have some of these tests `allow_failure`.

Fixes ocaml#2298

Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
ejgallego added a commit to ejgallego/dune that referenced this issue Jun 30, 2020
@ejgallego
[ci] Test with OCaml trunk / beta
fce6474 
We may want to have some of these tests `allow_failure`.

Fixes ocaml#2298

Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
ejgallego added a commit to ejgallego/dune that referenced this issue Jun 30, 2020
@ejgallego
[ocaml] Restore compatibility with OCaml 4.12
f7baa17 
OCaml 4.12 has introduced a new field in the `Gc.stats` record,
`forced_major_collections`. This makes compilation of Dune fail due to
`src/catapult/catapult.ml:fake_gc_stat`

We call `Gc.quick_stats` and override the set of safe fields.

Fixes: ocaml#3583

cc: ocaml#2298

Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
ejgallego added a commit to ejgallego/dune that referenced this issue Jun 30, 2020
@ejgallego
[ci] Test with OCaml trunk / beta
40f1611 
We may want to have some of these tests `allow_failure`.

Fixes ocaml#2298

Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
anmolsahoo25 pushed a commit to anmolsahoo25/dune that referenced this issue Aug 12, 2020
@ejgallego @rgrinberg
[ocaml] Restore compatibility with OCaml 4.12
5e1955a 
OCaml 4.12 has introduced a new field in the `Gc.stats` record,
`forced_major_collections`. This makes compilation of Dune fail due to
`src/catapult/catapult.ml:fake_gc_stat`

We call `Gc.quick_stats` and override the set of safe fields.

Fixes: ocaml#3583

cc: ocaml#2298

Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
rgrinberg pushed a commit that referenced this issue Aug 14, 2020
@ejgallego @rgrinberg
[ocaml] Restore compatibility with OCaml 4.12
d200c88 
OCaml 4.12 has introduced a new field in the `Gc.stats` record,
`forced_major_collections`. This makes compilation of Dune fail due to
`src/catapult/catapult.ml:fake_gc_stat`

We call `Gc.quick_stats` and override the set of safe fields.

Fixes: #3583

cc: #2298

Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
@Alizter
Copy link
Collaborator

Alizter commented Feb 13, 2023

@rgrinberg Do you think this is still worth perusing? It doesn't seem very likely that OCaml upstream will break Dune.

@rgrinberg
Copy link
Member

I think so.

@Alizter Alizter mentioned this issue Feb 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@rgrinberg @ejgallego @Alizter