[ocaml] Restore compatibility with OCaml 4.12 #3583
Comments
|
AFAIU, these stats are completely unused. So just using the result of |
|
They're just used in the expect tests for catapult. Since we don't emit a counter event for this field, |
ejgallego
added a commit
to ejgallego/dune
that referenced
this issue
Jun 29, 2020
OCaml 4.12 has introduced a new field in the `Gc.stats` record, `forced_major_collections`. This makes compilation of Dune fail due to `src/catapult/catapult.ml:fake_gc_stat` We call `Gc.quick_stats` and override the set of safe fields. Fixes: ocaml#3583 cc: ocaml#2298
ejgallego
added a commit
to ejgallego/dune
that referenced
this issue
Jun 29, 2020
OCaml 4.12 has introduced a new field in the `Gc.stats` record, `forced_major_collections`. This makes compilation of Dune fail due to `src/catapult/catapult.ml:fake_gc_stat` We call `Gc.quick_stats` and override the set of safe fields. Fixes: ocaml#3583 cc: ocaml#2298
ejgallego
added a commit
to ejgallego/dune
that referenced
this issue
Jun 29, 2020
OCaml 4.12 has introduced a new field in the `Gc.stats` record, `forced_major_collections`. This makes compilation of Dune fail due to `src/catapult/catapult.ml:fake_gc_stat` We call `Gc.quick_stats` and override the set of safe fields. Fixes: ocaml#3583 cc: ocaml#2298 Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
ejgallego
added a commit
to ejgallego/dune
that referenced
this issue
Jun 29, 2020
OCaml 4.12 has introduced a new field in the `Gc.stats` record, `forced_major_collections`. This makes compilation of Dune fail due to `src/catapult/catapult.ml:fake_gc_stat` We call `Gc.quick_stats` and override the set of safe fields. Fixes: ocaml#3583 cc: ocaml#2298 Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
ejgallego
added a commit
to ejgallego/dune
that referenced
this issue
Jun 30, 2020
OCaml 4.12 has introduced a new field in the `Gc.stats` record, `forced_major_collections`. This makes compilation of Dune fail due to `src/catapult/catapult.ml:fake_gc_stat` We call `Gc.quick_stats` and override the set of safe fields. Fixes: ocaml#3583 cc: ocaml#2298 Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
ejgallego
added a commit
to ejgallego/dune
that referenced
this issue
Jun 30, 2020
OCaml 4.12 has introduced a new field in the `Gc.stats` record, `forced_major_collections`. This makes compilation of Dune fail due to `src/catapult/catapult.ml:fake_gc_stat` We call `Gc.quick_stats` and override the set of safe fields. Fixes: ocaml#3583 cc: ocaml#2298 Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
anmolsahoo25
pushed a commit
to anmolsahoo25/dune
that referenced
this issue
Aug 12, 2020
OCaml 4.12 has introduced a new field in the `Gc.stats` record, `forced_major_collections`. This makes compilation of Dune fail due to `src/catapult/catapult.ml:fake_gc_stat` We call `Gc.quick_stats` and override the set of safe fields. Fixes: ocaml#3583 cc: ocaml#2298 Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
rgrinberg
pushed a commit
that referenced
this issue
Aug 14, 2020
OCaml 4.12 has introduced a new field in the `Gc.stats` record, `forced_major_collections`. This makes compilation of Dune fail due to `src/catapult/catapult.ml:fake_gc_stat` We call `Gc.quick_stats` and override the set of safe fields. Fixes: #3583 cc: #2298 Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
OCaml 4.12 has introduced a new field in the
Gc.statsrecord,forced_major_collections. This makes compilation of Dune fail due tosrc/catapult/catapult.ml:fake_gc_statThere could be several solutions to this, such as calling
Gc.quick_statsand then overriding the set of safe fields, but OMMV.cc: #2298
The text was updated successfully, but these errors were encountered: