Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] conduit, conduit-mirage, conduit-lwt, conduit-lwt-unix and conduit-async (5.0.0) #19819

Merged
merged 5 commits into from
Oct 21, 2021

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Oct 20, 2021

A network connection establishment library

CHANGES:

…and conduit-async (5.0.0)

CHANGES:

* change the type of `Conduit_lwt_tls.X509.default_authenticator` and
  `Conduit_lwt_unix.default_ctx` to be lazy, avoiding various side-effects
  (system interactions, logging) due to constructing these values at
  initialisation time. (@craigfe, mirage/ocaml-conduit#395 mirage/ocaml-conduit#404)
* Adapt conduit-mirage to dns-client 6.0.0 API (mirage/ocaml-conduit#406 @hannesm)
* Use Lwt.pause instead of Lwt_unix.yield (mirage/ocaml-conduit#403 @MisterDA)
* Avoid deprecated Fmt.kstrf (mirage/ocaml-conduit#407 @hannesm)
@hannesm
Copy link
Member Author

hannesm commented Oct 20, 2021

note: compilation failures that pop up in lower-bounds of cohttp-lwt-unix (re and cpp0) won't be fixed by this PR, which is already putting quite some pressure on the CI.

@hannesm
Copy link
Member Author

hannesm commented Oct 20, 2021

ok, so from the CI I see that mirage/ocaml-conduit#395 (where @craigfe wrapped the trust anchors into a Lazy.t to fix mirage/ocaml-conduit#388) did some API breaking:

I added upper bounds for the three packages mentioned above, eventually the maintainers (mentioned) are interested to upgrade their packages.

@hannesm
Copy link
Member Author

hannesm commented Oct 20, 2021

CI looks promising, as mentioned I added some upper bounds, and there are some lower bound failures (re and cpp0 fail to install; aws-s3-lwt needs some cmdliner lower bound). To lower the pressure on the CI (and since it is not related to the core of this PR) I won't fix any of that in this PR. This is fine to be merged.

@samoht
Copy link
Member

samoht commented Oct 21, 2021

Thanks!

@samoht samoht merged commit 71b117f into ocaml:master Oct 21, 2021
@hannesm hannesm deleted the release-conduit-v5.0.0 branch October 21, 2021 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants