Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

with 1.5.1, bad urls for subsequent packages #402

Closed
hannesm opened this issue Oct 20, 2021 · 2 comments · Fixed by #404
Closed

with 1.5.1, bad urls for subsequent packages #402

hannesm opened this issue Oct 20, 2021 · 2 comments · Fixed by #404
Labels
bug Something isn't working

Comments

@hannesm
Copy link
Contributor

hannesm commented Oct 20, 2021

I ran dune-release distrib ... dune-release opam pkg / dune-release opam submit, and only the "main" package got a "v" in the url, the others did not (leading to 404 from opam-ci): ocaml/opam-repository#19818 fix in ocaml/opam-repository@9d5053d

not sure why this happens, and if this is an issue with happy-eyeballs (see ocurrent/ocaml-ci#381 which causes some other trouble). a local dune build does not work, but dune build -p happy-eyeballs and dune build -p happy-eyeballs-lwt,happy-eyeballs-mirage do.
@hannesm
Copy link
Contributor Author

hannesm commented Oct 20, 2021

same happened for the conduit release ocaml/opam-repository#19819 (fix ocaml/opam-repository@7dd80c7)

@Leonidas-from-XIV
Copy link
Member

Hi @hannesm, thanks for your report. I've looked into this and the issue seems to be that the .url file is only generated for the main artifact, the other artifacts get a default URL which is wrong if the tag starts with a v.

This is how after publish you run opam pkg:

dune-release: [WARNING] Could not find _build/dummy-sub-0.3.0~beta5.url.
dune-release: [WARNING] using https://github.com/Leonidas-from-XIV/dune-release-testing/releases/download/0.3.0~beta5/dummy-0.3.0~beta5.tbz for as url.src. Note that it might differ from the one generated by Github

@Leonidas-from-XIV Leonidas-from-XIV mentioned this issue Oct 28, 2021
Merged
@Leonidas-from-XIV Leonidas-from-XIV added the bug Something isn't working label Nov 1, 2021
@Leonidas-from-XIV Leonidas-from-XIV mentioned this issue Nov 5, 2021
Merged
Leonidas-from-XIV added a commit to Leonidas-from-XIV/opam-repository that referenced this issue Nov 5, 2021
@Leonidas-from-XIV
[new release] dune-release (1.5.2)
b6acd88 
CHANGES:

### Fixed

- Fixed the release asset URL for projects with multiple opam packages. Before,
  the packages would attempt to infer their URL and fail in rare cases where
  the project uses `v` as prefix for tags but the project version omits it. Now
  they share the same URL. (tarides/dune-release#402, tarides/dune-release#404, @Leonidas-from-XIV)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make all packages use the same asset url file Leonidas-from-XIV/dune-release
2 participants
@Leonidas-from-XIV @hannesm