Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] eio_main, eio_luv, eio_linux and eio (0.8.1) #23236

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

talex5
Copy link
Contributor

@talex5 talex5 commented Feb 5, 2023

CHANGES:

Some build fixes:

CHANGES:

Some build fixes:

- Fix build on various architectures (@talex5 ocaml-multicore/eio#432).
  - Work around dune `%{system}` bug.
  - eio_luv: fix `max_luv_buffer_size` on 32-bit platforms.

- Add missing test-dependency on MDX (@talex5 ocaml-multicore/eio#430).
@talex5
Copy link
Contributor Author

talex5 commented Feb 5, 2023

@talex5
Copy link
Contributor Author

talex5 commented Feb 6, 2023

I think this is ready to merge now. The two expected failures correspond to real bugs in other libraries, and the mac failure (Uncaught exception: Failure("\"rsync\") is unrelated.

@raphael-proust
Copy link
Contributor

I made #23271 to mark luv as not available on s390x.

@talex5 do you think that's the appropriate change to make? Do you know if the error exists also for ocaml≠5?

@talex5
Copy link
Contributor Author

talex5 commented Feb 9, 2023

I made #23271 to mark luv as not available on s390x.

I'd slightly prefer not to do that. eio_main depends on eio_luv (as a fallback) and making luv uninstallable will therefore prevent eio_main from working in all cases.

But I don't think we have any users on s390x yet, so it's not a big problem.

@kit-ty-kate
Copy link
Member

Thanks

@kit-ty-kate kit-ty-kate merged commit 9cff312 into ocaml:master Feb 9, 2023
@talex5 talex5 deleted the release-eio-v0.8.1 branch February 9, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants