Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] mirage-crypto, mirage-crypto-rng, mirage-crypto-rng-mirage, mirage-crypto-rng-lwt, mirage-crypto-rng-eio, mirage-crypto-rng-async, mirage-crypto-pk and mirage-crypto-ec (0.11.0) #23237

Closed
wants to merge 1 commit into from

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Feb 5, 2023

Simple symmetric cryptography for the modern age

CHANGES:

…age, mirage-crypto-rng-lwt, mirage-crypto-rng-eio, mirage-crypto-rng-async, mirage-crypto-pk and mirage-crypto-ec (0.11.0)

CHANGES:

- BREAKING split mirage-crypto-rng-lwt away from mirage-crypto-rng (mirage/mirage-crypto#168
  @hannesm, reported by @bikallem mirage/mirage-crypto#158)
- AEAD API improvements: provide tag_size, of_secret, and functions that deal
  with the tag separately (mirage/mirage-crypto#171 @hannesm, fixes mirage/mirage-crypto#74 mirage/mirage-crypto#144 @orbitz @anmonteiro)
  Only CCM16 (with tag size 16) is now exposed, the former API does not exist
  anymore (passing `~maclen` to `of_secret`), according to sherlocode the only
  usage was CCM16 anyways
- BREAKING unify RNG initialization (reported by @talex5 in mirage/mirage-crypto#155, fixes mirage/mirage-crypto#160,
  PR mirage/mirage-crypto#162 @hannesm)
- remove mirage 3 cross-compilation runes (mirage/mirage-crypto#163 @hannesm)
- CI: mirage-crypto-rng-eio requires ocaml 5 and dune 2.7 (mirage/mirage-crypto#170 @hannesm, fixes
  mirage/mirage-crypto#169 thanks to @bikallem @talex5)
- CI: use miage 4 (mirage/mirage-crypto#166 @hannesm)
@hannesm
Copy link
Member Author

hannesm commented Feb 5, 2023

I'm pretty sure some revdeps will fail (mirage-crypto-rng-lwt is now separate from mirage-crypto-rng to ease the dependency cone), I'll open separate PRs to restrict them from using 0.11 //cc @mbacarella @bikallem

@hannesm
Copy link
Member Author

hannesm commented Feb 5, 2023

maybe @talex5 or @bikallem have an idea why o arm32 and OCaml 5 the mirage-crypto-rng-eio fails? Since I don't have the resources, I'd restrict that package to arm64 and amd64 only (or disabling it on 32bit platforms) - WDYT?

#=== ERROR while compiling mirage-crypto-rng-eio.0.11.0 =======================#
# context              2.2.0~alpha~dev | linux/arm32 | ocaml-base-compiler.5.0.0 | pinned(https://github.com/mirage/mirage-crypto/releases/download/v0.11.0/mirage-crypto-0.11.0.tbz)
# path                 ~/.opam/5.0/.opam-switch/build/mirage-crypto-rng-eio.0.11.0
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune runtest -p mirage-crypto-rng-eio -j 79
# exit-code            1
# env-file             ~/.opam/log/mirage-crypto-rng-eio-7-f84e66.env
# output-file          ~/.opam/log/mirage-crypto-rng-eio-7-f84e66.out
### output ###
# File "tests/dune", line 74, characters 25-52:
# 74 |  (names     test_eio_rng test_eio_entropy_collection)
#                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^
# (cd _build/default/tests && ./test_eio_entropy_collection.exe)
# Fatal error: exception Invalid_argument("Cstruct.split [0,128](128) start=0 off=-1")
# File "tests/dune", line 74, characters 12-24:
# 74 |  (names     test_eio_rng test_eio_entropy_collection)
#                  ^^^^^^^^^^^^
# (cd _build/default/tests && ./test_eio_rng.exe)
# Fatal error: exception Invalid_argument("Cstruct.split [0,128](128) start=0 off=-1")

@talex5
Copy link
Contributor

talex5 commented Feb 5, 2023

It's probably ocaml-multicore/eio#432 - it should start working once the new Eio release is merged (#23236).

@hannesm
Copy link
Member Author

hannesm commented Feb 5, 2023

Thanks @talex5. FWIW I opened revdep fixes, and will close this PR until these revdep PRs are merged (to reduce CI load).

@hannesm
Copy link
Member Author

hannesm commented Feb 9, 2023

Dear valued maintainer, I'd really like to move forward with this release -- and thus would appreciate if you could merge #23238 #23239 #23240 #23242 -- which sole purpose is to add upper bounds to packages incompatible with this new mirage-crypto release. Are there any steps I can do to ease your workflow and get these mentioned PRs merged (I understand they entail CI failures, but these were present before, take a look at the respective diffs to convince yourself)?

Thanks a lot for your continuous effort keeping the opam-repository in a working state :) 👍🏾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RNG initialization inconsistencies AEAD interface improvements
2 participants