Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

further mirage-crypto 0.11.0 breaking reverse dependencies: #23240

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Feb 5, 2023

in order to fix #23237 revdeps

(a) Mirage_crypto_rng_lwt is now in the separate package mirage-crypto-rng-lwt (b) Mirage_crypto_rng_unix.initialize signature changed

  • dream
  • hyper
  • jose
  • letsencrypt
  • rfc6287
  • ssh-agent
  • twostep

And in mirage-block-ccm: now AES.CCM16, no AES.CCM anymore

(a) Mirage_crypto_rng_lwt is now in the separate package mirage-crypto-rng-lwt
(b) Mirage_crypto_rng_unix.initialize signature changed
- dream
- hyper
- jose
- letsencrypt
- rfc6287
- ssh-agent
- twostep

And in mirage-block-ccm: now AES.CCM16, no AES.CCM anymore
@hannesm hannesm changed the title further breaking dependencies: further mirage-crypto 0.11.0 breaking reverse dependencies: Feb 5, 2023
@ulrikstrid
Copy link
Contributor

Just to be clear, for tests I can just do this if I want to upgrade right?

let () =
  Mirage_crypto_rng.default_generator () |> Mirage_crypto_rng_unix.initialize

@hannesm
Copy link
Member Author

hannesm commented Feb 6, 2023

@ulrikstrid thanks for reaching out, I plan to write a small note into the final changelog, but basically your

let () = Mirage_crypto_rng_unix.initialize ()

will now be:

let () = Mirage_crypto_rng_unix.initialize (module Mirage_crypto_rng.Fortuna)

The change is motivated by uniformity of the initialize function (present for _unix, _eio, _async, _mirage, _lwt) -- now passing the desired RNG module explicitly.

@hannesm
Copy link
Member Author

hannesm commented Feb 6, 2023

The CI failures are unrelated. Good to merge.

@kit-ty-kate
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants