Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] tls, tls-mirage, tls-lwt, tls-eio and tls-async (0.16.0) #23311

Merged
merged 3 commits into from
Feb 16, 2023

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Feb 14, 2023

Transport Layer Security purely in OCaml

CHANGES:

CHANGES:

* BREAKING: new opam package tls-lwt (formerly tls.lwt), in dune:
  (libraries tls.lwt) should now be libraries (tls-lwt)
  (mirleft/ocaml-tls#468 @hannesm, reported mirleft/ocaml-tls#449 by @mbacarella)
* tls: update to mirage-crypto 0.11 API (mirleft/ocaml-tls#468 @hannesm)
* tls: relax SignatureAlgorithms extension handling to allow OpenSSL
  interoperability tests with TLS 1.0 and TLS 1.1 (mirleft/ocaml-tls#469 @hannesm)
* tls: remove Utils.filter_map and and Utils.option, use Stdlib instead (mirleft/ocaml-tls#455
  @hannesm)
* tls: do not globally open Utils (mirleft/ocaml-tls#455 @hannesm)
* tls: export log source of Tracing module (mirleft/ocaml-tls#461 @bikallem)
* tls: remove unused ciphersuites to reduce binary size (mirleft/ocaml-tls#467 @hannesm)
* tls-lwt: do not catch out of memory exception (mirleft/ocaml-tls#469 @hannesm)
* tls-eio: add fuzz testing using crowbar (mirleft/ocaml-tls#456 mirleft/ocaml-tls#463 @talex5)
* tls-eio: update to eio 0.7 (mirleft/ocaml-tls#456 @talex5)
* tls-eio: fix test for develop with vendoring (mirleft/ocaml-tls#462 @bikallem)
@hannesm
Copy link
Member Author

hannesm commented Feb 14, 2023

Since ocamlfind's tls.lwt is now tls-lwt, there's expectation of failures (in addition to the API changes in #23282). I'll observe the CI and add in separate PR(s) upper bound constraints (of course, anyone helping out is highly appreciated).

@hannesm
Copy link
Member Author

hannesm commented Feb 14, 2023

I have a question for both the opam-repository maintainers and @talex5: the tls-async.opam has a "ocaml" {< "5.0.0"} bound, and I understand this was useful at some point for some CI system(s) -- but is this the right thing to have? I do not think that anything in tls-async is incompatible with OCaml 5.0. Any advice on this is highly appreciated (I test the relaxation at mirleft/ocaml-tls#471).

@hannesm
Copy link
Member Author

hannesm commented Feb 14, 2023

update: I removed the upper bound for ocaml

@talex5
Copy link
Contributor

talex5 commented Feb 14, 2023

I have a question for both the opam-repository maintainers and @talex5: the tls-async.opam has a "ocaml" {< "5.0.0"} bound, and I understand this was useful at some point for some CI system(s) -- but is this the right thing to have?

mirleft/ocaml-tls@ea1631c says:

  • Temporary fix for tls-async in CI
    tls-async can't be tested on OCaml 5 yet, and this prevents the CI from
    testing other packages there. This annotation can be removed once a
    compatible version of core is released.

So it should be fine to remove it now (v0.15.1 seems to work with OCaml 5).

@hannesm hannesm mentioned this pull request Feb 14, 2023
Co-authored-by: Kate <kit.ty.kate@disroot.org>
@hannesm
Copy link
Member Author

hannesm commented Feb 16, 2023

@dinosaure
Copy link
Contributor

The error on MacOS seems unrelated to this release, let's merge :)

@dinosaure dinosaure merged commit 25d997b into ocaml:master Feb 16, 2023
@hannesm hannesm deleted the release-tls-v0.16.0 branch February 16, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants