paf-cohttp.0.{0,2,3,4}.0 and paf-cohttp.0.0.{6,7,8,8-1,9} are incompatible with mirage-crypto-rng.0.11.0 #23322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tible with mirage-crypto-rng.0.11.0
|
thanks, I just prepared the same commit, what you need as well is hannesm@b0e5821 to restrict git-unix 2.1.3 |
|
see #23311 |
|
It should pass linting as well now. Once the linter has gone through we can merge |
|
Thanks |
emillon
added a commit
to emillon/opam-repository
that referenced
this pull request
Feb 20, 2023
Similar to ocaml#23322: #=== ERROR while compiling git-unix.3.12.0 ====================================# # context 2.2.0~alpha~dev | linux/x86_64 | ocaml-base-compiler.5.0.0 | file:///home/opam/opam-repository # path ~/.opam/5.0/.opam-switch/build/git-unix.3.12.0 # command ~/.opam/opam-init/hooks/sandbox.sh build dune runtest -p git-unix -j 71 --no-buffer # exit-code 1 # env-file ~/.opam/log/git-unix-7-4542c2.env # output-file ~/.opam/log/git-unix-7-4542c2.out ### output ### # File "_none_", line 1: # Alert ocaml_deprecated_auto_include: # OCaml's lib directory layout changed in 5.0. The unix subdirectory has been # automatically added to the search path, but you should add -I +unix to the # command-line to silence this alert (e.g. by adding unix to the list of # libraries in your dune file, or adding use_unix to your _tags file for # ocamlbuild, or using -package unix for ocamlfind). # File "test/smart/test.ml", line 57, characters 43-45: # 57 | let () = Mirage_crypto_rng_unix.initialize () # ^^ # Error: This expression has type unit but an expression was expected of type # 'a Mirage_crypto_rng.generator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted by the
tlsrevdeps:tls.0.16.0
revdeps
git-unix.2.1.3 (failed: This expression should not be a unit literal, the expected type is)
paf-cohttp.0.0.6 (failed: This expression should not be a unit literal, the expected type is)
paf-cohttp.0.0.7 (failed: This expression should not be a unit literal, the expected type is)
paf-cohttp.0.0.8 (failed: This expression should not be a unit literal, the expected type is)
paf-cohttp.0.0.8-1 (failed: This expression should not be a unit literal, the expected type is)
paf-cohttp.0.0.9 (failed: This expression should not be a unit literal, the expected type is)
paf-cohttp.0.2.0 (failed: This expression should not be a unit literal, the expected type is)
paf-cohttp.0.3.0 (failed: This expression should not be a unit literal, the expected type is)
paf-cohttp.0.4.0 (failed: This expression should not be a unit literal, the expected type is)