-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct the bytecode architectures for OCaml 5.1 and OCaml 5.2 (trunk) #24075
Conversation
This is a draft for two reasons:
|
8d2d963
to
71c1bd2
Compare
ocaml-option-bytecode-only pulled in only for ppc64. Technically, s390x wasn't available in native code for alpha1.
71c1bd2
to
3985a57
Compare
OK, I've changed the scope of this slightly, in order to allow the two bugs to be fixed more quickly. This revised version now only affects the 5.1 and 5.2 packages (i.e. it's clearly the case that released switches are unaffected). It's also a good deal easier to review as a result 🙂 I have again tested these on s390x and ppc64
The critical fix is that if Fixing the slight mess with |
This looks right to me (and is surprisingly complex!). There are also a number of 32-bit-related options in the configure step which look redundant to me now, but can be fixed in a future PR. Is the idea to get this correct in opam-repository, and then submit a fix to ocaml/ocaml for the trunk metadata to be correct, @dra27? That would help @Octachron with release generation. |
I confess I hadn't considered the It's not related to the release process, though - I'm fairly sure @Octachron uses the previous packages in opam-repository as the starting point for the following release.
Yes, indeed! Now that 5.1 has confirmed their removal, those really ought to be simplified. I've added to the list of bits to check along with the Windows parts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The constraints LGTM, reflecting that
- the native riscv backend was restored with 5.1.0~alpha1
- the native s390x backend was restored with 5.1.0~alpha2 and
- the ppc64 port has been merged into trunk (5.2).
This PR fixes two small issues:
ocaml-option-bytecode-only
package for ppc64I've extensively tested this (hopefully!) on amd64, ppc64 and s390x. The important details:
ocaml-options-vanilla
package)