Correct 32-bit architectures for 5.1 and 5.2 #24130
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alas, in #24075 I correctly fixed the bytecode-only 64-bit architectures in 5.1 and 5.2 and incorrectly broke the 32-bit architectures.
32-bit architectures can be written as
arch = "x86_32" | arch = "arm32" | arch = "ppc32"
, but I think it's better to put what @Octachron had originally put in the 5.1.0~alpha2 package and have a conjunction of the supported native architectures which is what I've done here (cf. also ocaml/opam#4633).cc @tmcgilchrist