-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package apron.v0.9.14~beta.2 #24090
Package apron.v0.9.14~beta.2 #24090
Conversation
depopts: [ | ||
"conf-ppl" | ||
"conf-pplite" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no conf-pplite package in opam-repository though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no conf-pplite package in opam-repository though.
Yes. This was copied from ppl. Given that (unlike ppl) there's no pplite package for standard distributions (that I know of), adding a conf-pplite
package may not be very useful. I suggest we remove this, and let the ./configure
script decide if pplite should be compiled in. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A conf-pplite package might not be that unreasonable because the ./configure
check might be close to how packages like conf-ppl do the check as well. Not having system packages and depexts maybe isn't an issue for having a conf-* package.
opam-repository maintainers probably know the best how they'd like things. Seems like opam and the CI don't really care that a depopt doesn't exist at all, so maybe it's fine as-is. If a conf-pplite package is created, then it'll also configure this package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with this, but I'd like to have the conf-pplite
package as well, even if for the time being the list of depexts is empty. I think you can base it on https://github.com/ocaml/opam-repository/blob/master/packages/conf-ppl/conf-ppl.1/opam (or even simpler using conf-pkg-config if ppxlite supports pkg-config)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know, pplite has no package installer from standard distribution, so, it's quite different from ppl. I think it is better to remove the dependency on conf-pplite until there is some more reason to include such a package.
CI reports
revdep (elina.1.3) CI failure``` <><> Processing actions <><><><><><><><><><><><><><><><><><><><><><><><><><><><> [ERROR] Failed to get sources of elina.1.3: Bad checksum#=== ERROR while fetching sources for elina.1.3 ===============================# <><> Error report <><><><><><><><><><><><><><><><><><><><><><><><><><><><><><><>
Run eval $(opam env) to update the current shell environment"/bin/bash" "-c" "opam reinstall elina.1.3;
|
./configure decides whether to include pplite support
Is there anything preventing the merge of this opam package? |
It looks fine, sorry for the long wait. I am just re-running the failing tests to make sure that I have fixed the necessary bounds |
apron.v0.9.14~beta.2
APRON numerical abstract domain library
Apron is a library to represent properties of numeric variables, such as variable bounds or linear relations between variables, and to manipulate these properties through semantic operations, such as variable assignments, tests, conjunctions, entailment. Apron is intended to be used in static program analyzers, in order to infer invariants of numeric variables, i.e., properties that hold for all executions of a program. It is based on the theory of Abstract Interpretation.
🐫 Pull-request generated by opam-publish v2.2.0