Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package apron.v0.9.14~beta.2 #24090

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

antoinemine
Copy link
Contributor

apron.v0.9.14~beta.2

APRON numerical abstract domain library
Apron is a library to represent properties of numeric variables, such as variable bounds or linear relations between variables, and to manipulate these properties through semantic operations, such as variable assignments, tests, conjunctions, entailment. Apron is intended to be used in static program analyzers, in order to infer invariants of numeric variables, i.e., properties that hold for all executions of a program. It is based on the theory of Abstract Interpretation.



🐫 Pull-request generated by opam-publish v2.2.0

Comment on lines 40 to 42
depopts: [
"conf-ppl"
"conf-pplite"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no conf-pplite package in opam-repository though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no conf-pplite package in opam-repository though.

Yes. This was copied from ppl. Given that (unlike ppl) there's no pplite package for standard distributions (that I know of), adding a conf-pplite package may not be very useful. I suggest we remove this, and let the ./configure script decide if pplite should be compiled in. What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A conf-pplite package might not be that unreasonable because the ./configure check might be close to how packages like conf-ppl do the check as well. Not having system packages and depexts maybe isn't an issue for having a conf-* package.

opam-repository maintainers probably know the best how they'd like things. Seems like opam and the CI don't really care that a depopt doesn't exist at all, so maybe it's fine as-is. If a conf-pplite package is created, then it'll also configure this package.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with this, but I'd like to have the conf-pplite package as well, even if for the time being the list of depexts is empty. I think you can base it on https://github.com/ocaml/opam-repository/blob/master/packages/conf-ppl/conf-ppl.1/opam (or even simpler using conf-pkg-config if ppxlite supports pkg-config)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know, pplite has no package installer from standard distribution, so, it's quite different from ppl. I think it is better to remove the dependency on conf-pplite until there is some more reason to include such a package.

@haochenx
Copy link
Member

haochenx commented Jul 12, 2023

CI reports

revdep (elina.1.3) CI failure ``` <><> Processing actions <><><><><><><><><><><><><><><><><><><><><><><><><><><><> [ERROR] Failed to get sources of elina.1.3: Bad checksum

#=== ERROR while fetching sources for elina.1.3 ===============================#
OpamSolution.Fetch_fail("https://github.com/eth-sri/ELINA/archive/1.3.tar.gz (Bad checksum, expected md5=e0c78d7b0a7afaee871a057b83d06a76)")

<><> Error report <><><><><><><><><><><><><><><><><><><><><><><><><><><><><><><>
+- The following actions failed
| - fetch elina 1.3
+-

  • No changes have been performed

Run eval $(opam env) to update the current shell environment

"/bin/bash" "-c" "opam reinstall elina.1.3;
res=$?;
test "$res" != 31 && exit "$res";
export OPAMCLI=2.0;
build_dir=$(opam var prefix)/.opam-switch/build;
failed=$(ls "$build_dir");
partial_fails="";
for pkg in $failed; do
if opam show -f x-ci-accept-failures: "$pkg" | grep -qF ""debian-11""; then
echo "A package failed and has been disabled for CI using the 'x-ci-accept-failures' field.";
fi;
test "$pkg" != 'elina.1.3' && partial_fails="$partial_fails $pkg";
done;
test "${partial_fails}" != "" && echo "opam-repo-ci detected dependencies failing: ${partial_fails}";
exit 1" failed with exit status 40
2023-07-11 07:36.37: Job failed: Failed: Build failed
2023-07-11 07:36.37: Log analysis:
2023-07-11 07:36.37: >>>
[ERROR] Failed to get sources of elina.1.3: Bad checksum
(score = 25)
2023-07-11 07:36.37: Failed to get sources of elina.1.3: Bad checksum

</details>

./configure decides whether to include pplite support
@antoinemine
Copy link
Contributor Author

Is there anything preventing the merge of this opam package?

@mseri
Copy link
Member

mseri commented Aug 15, 2023

It looks fine, sorry for the long wait. I am just re-running the failing tests to make sure that I have fixed the necessary bounds

@mseri mseri merged commit ba25ecf into ocaml:master Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants