Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package apron.v0.9.14~beta.2 #24090

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Package apron.v0.9.14~beta.2 #24090

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f54ab6f
Package apron.v0.9.14~beta.2
antoinemine Jul 10, 2023
ae4e76a
removed references to (inexistent) conf-pplite package
antoinemine Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions packages/apron/apron.v0.9.14~beta.2/opam
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
opam-version: "2.0"
synopsis: "APRON numerical abstract domain library"
authors: [
"Bertrand Jeannet"
"Antoine Miné"
"https://github.com/antoinemine/apron/graphs/contributors"
]
license: "LGPL-2.1-only WITH OCaml-LGPL-linking-exception"
homepage: "https://antoinemine.github.io/Apron/doc/"
maintainer: "Nicolas Berthier <m@nberth.space>"
dev-repo: "git+https://github.com/antoinemine/apron.git"
bug-reports: "https://github.com/antoinemine/apron/issues"
build: [
[
"sh"
"./configure"
"--prefix"
"%{share}%/apron"
"--no-ppl" {!conf-ppl:installed}
"--no-pplite" {!conf-pplite:installed}
"--no-ocaml-plugins" {os = "freebsd"}
"--absolute-dylibs" {os = "macos"}
"--ext-dll" {os = "win32"} "dll" {os = "win32"}
"--debug"
"--no-strip"
]
[make "-j%{jobs}%"]
]
install: [
[make "install"]
]
depends: [
"ocaml"
"ocamlfind" {build}
"camlidl"
"mlgmpidl"
"ocamlbuild" {build}
"conf-perl"
]
depopts: [
"conf-ppl"
"conf-pplite"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no conf-pplite package in opam-repository though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no conf-pplite package in opam-repository though.

Yes. This was copied from ppl. Given that (unlike ppl) there's no pplite package for standard distributions (that I know of), adding a conf-pplite package may not be very useful. I suggest we remove this, and let the ./configure script decide if pplite should be compiled in. What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A conf-pplite package might not be that unreasonable because the ./configure check might be close to how packages like conf-ppl do the check as well. Not having system packages and depexts maybe isn't an issue for having a conf-* package.

opam-repository maintainers probably know the best how they'd like things. Seems like opam and the CI don't really care that a depopt doesn't exist at all, so maybe it's fine as-is. If a conf-pplite package is created, then it'll also configure this package.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with this, but I'd like to have the conf-pplite package as well, even if for the time being the list of depexts is empty. I think you can base it on https://github.com/ocaml/opam-repository/blob/master/packages/conf-ppl/conf-ppl.1/opam (or even simpler using conf-pkg-config if ppxlite supports pkg-config)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know, pplite has no package installer from standard distribution, so, it's quite different from ppl. I think it is better to remove the dependency on conf-pplite until there is some more reason to include such a package.

]
description:"""
Apron is a library to represent properties of numeric variables, such as variable bounds or linear relations between variables, and to manipulate these properties through semantic operations, such as variable assignments, tests, conjunctions, entailment. Apron is intended to be used in static program analyzers, in order to infer invariants of numeric variables, i.e., properties that hold for all executions of a program. It is based on the theory of Abstract Interpretation."""
url {
src:
"https://github.com/antoinemine/apron/archive/refs/tags/v0.9.14-beta.2.tar.gz"
checksum: [
"md5=b7f9ea6838057458c878f46ea4c9dede"
"sha512=bc2cbcf601c0d6deb75028ef7da4b485350665a09c4f9ed9146107aeed65edb055207a02a52bc279c2b506e9c5922371035fb00d0ae2cbfec3a9a760ecebf1bd"
]
}