omd archive link update #24642
omd archive link update #24642
Conversation
haochenx
commented
Oct 18, 2023
•
haochenx
commented
- another take of Update links to old versions of omd #23600 (which seems to be inactive)
- will proceed to replace all versions with available tarballs and use software heritage for the else
| src: "http://pw374.github.io/distrib/omd/omd-0.5.tar.gz" | ||
| checksum: "md5=d343deacc270674828260b0fdc55f74c" | ||
| src: "https://github.com/ocaml/omd/archive/refs/tags/0.5.tar.gz" | ||
| checksum: "sha256=fc462bf7b8f896f924fef610da436d9152168676adca2d606233101eb67e9432" |
There was a problem hiding this comment.
| checksum: "sha256=fc462bf7b8f896f924fef610da436d9152168676adca2d606233101eb67e9432" | |
| checksum: [ | |
| "sha256=fc462bf7b8f896f924fef610da436d9152168676adca2d606233101eb67e9432" | |
| "md5=d343deacc270674828260b0fdc55f74c" | |
| ] |
There was a problem hiding this comment.
if the archives are not the same, do we still want the md5 hash?
| src: "http://pw374.github.io/distrib/omd/omd-1.2.0.tar.gz" | ||
| checksum: "md5=2a1aa5144466a466e33b34de855bcd1c" | ||
| src: "https://github.com/ocaml/omd/archive/refs/tags/1.2.0.tar.gz" | ||
| checksum: "sha256=180465a930f27be1bf82bb4709f900cad0d7c69820c0c4efa98573242287637e" |
There was a problem hiding this comment.
| checksum: "sha256=180465a930f27be1bf82bb4709f900cad0d7c69820c0c4efa98573242287637e" | |
| checksum: [ | |
| "sha256=180465a930f27be1bf82bb4709f900cad0d7c69820c0c4efa98573242287637e" | |
| "md5=2a1aa5144466a466e33b34de855bcd1c" | |
| ] |
And the same for all of them. Are the tarballs identical? If now, we should try to find them in the cache and upload them on the opam-source-archives repo
There was a problem hiding this comment.
I hoped them to be the same, but they are different (at least for the ones that I have checked.) That's why I removed the old checksum.
If now, we should try to find them in the cache and upload them on the opam-source-archives repo
Do you mean if they are not different, we should cache and upload?
I was not able to find archives that have the same hash. I tried https://github.com/ocaml/omd, https://github.com/pw374/omd, and Software Heritage, and they are all different from the recorded hash
There was a problem hiding this comment.
The cache that I mean is either of
- https://opam.robur.coop/cache/md5/2a/2a1aa5144466a466e33b34de855bcd1c -- this package is not there unfortunately
- https://opam.ocaml.org/cache/md5/2a/2a1aa5144466a466e33b34de855bcd1c -- this package is not there unfortunately
there is a similar URL for the other hashes.
In this case, in the past we marked the package as unavailable since we could not compare the tarball contents with the original ones. I think we should discuss this specific case at the next maintainers meeting
There was a problem hiding this comment.
Thanks for clarification. Let's discuss this further next week.
There was a problem hiding this comment.
@mseri do you mind to add it as an item to https://github.com/ocaml/opam-repository/wiki/Meeting-notes? I don't have the permission to modify the wiki page
There was a problem hiding this comment.
|
This cannot be built as is, one needs to regenerate the setup.ml. |
See ocaml#24642 Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
See ocaml#24642 Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
