Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omd archive link update #24642

Closed
wants to merge 2 commits into from
Closed

omd archive link update #24642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e01076
update omd.0.5 archive link
haochenx Oct 18, 2023
e8ba0f3
update archive link for a few old omd versions (0.5, 1.2.*)
haochenx Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/omd/omd.0.5/opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,6 @@ markdown features."""
flags: light-uninstall
extra-files: ["omd.install" "md5=0395736894a46f718a77f59ec6fbf1fd"]
url {
src: "http://pw374.github.io/distrib/omd/omd-0.5.tar.gz"
checksum: "md5=d343deacc270674828260b0fdc55f74c"
src: "https://github.com/ocaml/omd/archive/refs/tags/0.5.tar.gz"
checksum: "sha256=fc462bf7b8f896f924fef610da436d9152168676adca2d606233101eb67e9432"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
checksum: "sha256=fc462bf7b8f896f924fef610da436d9152168676adca2d606233101eb67e9432"
checksum: [
"sha256=fc462bf7b8f896f924fef610da436d9152168676adca2d606233101eb67e9432"
"md5=d343deacc270674828260b0fdc55f74c"
]

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the archives are not the same, do we still want the md5 hash?

}
4 changes: 2 additions & 2 deletions packages/omd/omd.1.2.0/opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,6 @@ with 0.9.x."""
flags: light-uninstall
extra-files: ["omd.install" "md5=0395736894a46f718a77f59ec6fbf1fd"]
url {
src: "http://pw374.github.io/distrib/omd/omd-1.2.0.tar.gz"
checksum: "md5=2a1aa5144466a466e33b34de855bcd1c"
src: "https://github.com/ocaml/omd/archive/refs/tags/1.2.0.tar.gz"
checksum: "sha256=180465a930f27be1bf82bb4709f900cad0d7c69820c0c4efa98573242287637e"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
checksum: "sha256=180465a930f27be1bf82bb4709f900cad0d7c69820c0c4efa98573242287637e"
checksum: [
"sha256=180465a930f27be1bf82bb4709f900cad0d7c69820c0c4efa98573242287637e"
"md5=2a1aa5144466a466e33b34de855bcd1c"
]

And the same for all of them. Are the tarballs identical? If now, we should try to find them in the cache and upload them on the opam-source-archives repo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hoped them to be the same, but they are different (at least for the ones that I have checked.) That's why I removed the old checksum.

If now, we should try to find them in the cache and upload them on the opam-source-archives repo

Do you mean if they are not different, we should cache and upload?

I was not able to find archives that have the same hash. I tried https://github.com/ocaml/omd, https://github.com/pw374/omd, and Software Heritage, and they are all different from the recorded hash

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cache that I mean is either of

there is a similar URL for the other hashes.

In this case, in the past we marked the package as unavailable since we could not compare the tarball contents with the original ones. I think we should discuss this specific case at the next maintainers meeting

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarification. Let's discuss this further next week.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mseri do you mind to add it as an item to https://github.com/ocaml/opam-repository/wiki/Meeting-notes? I don't have the permission to modify the wiki page

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified in https://github.com/ocaml/opam-repository/wiki/Meetings-agenda

}
4 changes: 2 additions & 2 deletions packages/omd/omd.1.2.1/opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,6 @@ with 0.9.x."""
flags: light-uninstall
extra-files: ["omd.install" "md5=0395736894a46f718a77f59ec6fbf1fd"]
url {
src: "http://pw374.github.io/distrib/omd/omd-1.2.1.tar.gz"
checksum: "md5=6784ba3dbdd9b56029a8ef0509d61690"
src: "https://github.com/ocaml/omd/archive/refs/tags/1.2.1.tar.gz"
checksum: "sha256=fc1aaa6a1ec16edcc7ec41bdb43c85434e3863f9c576c4dd97faa30ab2d77942"
}
4 changes: 2 additions & 2 deletions packages/omd/omd.1.2.2/opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@ package installs both the OMD library and the command line tool `omd`."""
flags: light-uninstall
extra-files: ["omd.install" "md5=0395736894a46f718a77f59ec6fbf1fd"]
url {
src: "http://pw374.github.io/distrib/omd/omd-1.2.2.tar.gz"
checksum: "md5=3a3599c3c8241323d4ab30124deedab4"
src: "https://github.com/ocaml/omd/archive/refs/tags/1.2.2.tar.gz"
checksum: "sha256=29dcda616e8c5a348e4b98729043c29b74fdedc2ffa2c6409b919bc09a979528"
}
4 changes: 2 additions & 2 deletions packages/omd/omd.1.2.3/opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@ package installs both the OMD library and the command line tool `omd`."""
flags: light-uninstall
extra-files: ["omd.install" "md5=0395736894a46f718a77f59ec6fbf1fd"]
url {
src: "http://pw374.github.io/distrib/omd/omd-1.2.3.tar.gz"
checksum: "md5=31ed60d39aa0aaa337818fd62b56706b"
src: "https://github.com/ocaml/omd/archive/refs/tags/1.2.3.tar.gz"
checksum: "sha256=d212f5ee5d964e715749bbd2b44c640c056d769cc75e1b0d17307dc8823ddf25"
}
4 changes: 2 additions & 2 deletions packages/omd/omd.1.2.4/opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@ package installs both the OMD library and the command line tool `omd`."""
flags: light-uninstall
extra-files: ["omd.install" "md5=0395736894a46f718a77f59ec6fbf1fd"]
url {
src: "http://pw374.github.io/distrib/omd/omd-1.2.4.tar.gz"
checksum: "md5=083a56364a7046c4be868ccd8cc0f487"
src: "https://github.com/ocaml/omd/archive/refs/tags/1.2.4.tar.gz"
checksum: "sha256=b8dae556b973cb1b4373aa42aba37bdf4028aec36d1f9c0bb2d6949f562415f6"
}