alsa: add bound on ocaml version #7155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a build error on OSX due to missing depexts. /cc @smimram |
|
Wouldn't it be better to add the patch correcting the problem instead of limiting the OCaml version? Anyway, this is integrated upstream and should be fixed in next release. |
|
@smimram As far as I know, the current policy for OPAM packages is to limit usage of patches as much as possible, and get things fixed upstream instead because in the long term it avoids a lot of duplicate work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alsa doesn't compile on 4.04 because of the added check for wrong usage of
CAMLparam*. I've sent a PR upstream (savonet/ocaml-alsa#1).