CAMLlocal bug in stubs #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You cannot use the `CAMLlocal*` macros without an enclosing `CAMLparam*`, otherwise you end up accessing a piece of the stack that was deallocated (and potentially reused). OCaml 4.04.0 guards against this mistake. Since there is no allocation between the initialization of `ans` and the `return`, you don't need the call to `CAMLlocal1`.
|
Makes sense, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You cannot use the
CAMLlocal*macros without an enclosingCAMLparam*, otherwise you end up accessing a piece of the stack that was deallocated (and potentially reused). OCaml 4.04.0 guards against this mistake.Since there is no allocation between the initialization of
ansand thereturn, you don't need the call toCAMLlocal1.