Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `--unsafe-depext-yes' #4563

Closed
wants to merge 1 commit into from
Closed

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented Feb 25, 2021

For system package managers & change OPAMDEPEXTYES' to OPAMUNSAFEDEPEXTYES'
fix #4321

… change `OPAMDEPEXTYES' to `OPAMUNSAFEDEPEXTYES'
@rjbou rjbou added this to the 2.1.0~beta5 milestone Feb 25, 2021
Copy link
Member

@avsm avsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Once this is merged, we'll need to update ocaml-ci/opam-repo-ci to use the new env var. This could also use a note in the CHANGES file that the variable that used to work in the previous betas does not work now.

@rjbou
Copy link
Collaborator Author

rjbou commented Feb 25, 2021

In the release notes / blog post too. Also we shouldn't forget to specify that it will be removed in next release.

avsm added a commit to avsm/ocaml-base-images that referenced this pull request Mar 3, 2021
See ocaml/opam#4563

This currently just sets both, so we have a transition period and
can then remove the older env var.
@rjbou
Copy link
Collaborator Author

rjbou commented May 18, 2021

Superseed by #4582

@rjbou rjbou closed this May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command-line option needed for OPAMDEPEXTYES
2 participants