Introduce `--confirm-level' option #4582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjbou
added
PR: QUEUED
rjbou
changed the title
rjbou
removed
the
PR: QUEUED
|
From dev meeting:
|
rjbou
commented
Apr 23, 2021
rjbou
commented
Apr 23, 2021
dra27
reviewed
Apr 23, 2021
kit-ty-kate
reviewed
Apr 23, 2021
AltGr
approved these changes
May 19, 2021
dra27
reviewed
May 19, 2021
rjbou
commented
May 21, 2021
…to opam questions, and `--no` There is 3 levels, 4 states: * unsafe-yes: yes to all questions & launch system package manager in non interactive mode * yes: answers no to all questions, similar to `--yes` * no: answers no to all questions, similar to `--no` * ask (default): ask for all questions
…ars more than once
… than once. * yes and no, the one in the right is taken * confirm-level, the one in the right is taken * if yes/no & confirm-level are given, take confirm-level
* `{doc,init}_opam_envvariables' -> `{doc,init}_opam_env_variables'
dra27
reviewed
May 25, 2021
src/core/opamCoreConfig.ml
Outdated
| match E.confirmlevel (), E.yes (), E.no () with | ||
| | Some c, _, _ -> Some c | ||
| | _, Some true, _ -> Some `all_yes | ||
| | _, Some false, _ |
There was a problem hiding this comment.
Suggested change
| | _, Some false, _ | |
| | _, Some false, _ -> None |
At present, OPAMYES=false opam ... still prompts, where this would still answer no.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--confirm-levelto specify levels of automatic answer to opam questions, and--noThere is 3 levels:
--yes--noThose values can also be given to environment variable
OPAMCONFIRMLEVEL.Priorities:
OPAMCONFIRMLEVELif defined, thenOPAMYESif true, thenOPAMNOif true, kept undefined otherwise--yes,--no, and--confirm-levelcan be repeated. Only the last of--yesor--nois taken into account, and only the last--confirm-levelis taken into account. if--confirm-leveland--yes/noare both given,--confirm-levelcontent is taken.