confirm level/yes/no: better answer computation #4691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lags and environment variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic answering depends on several parameters: confirm-level, yes, and no cli flags and environment variables.
In #4582, environment computes an answer, cli flags another one, and those answers were compared to set the run answering (cli > env var). That lead to #4682.
One solution is to check each parameters against its environment variable / cli flags, and then compute the automatic answering. So in
OpamCore.Config.!r, answer is no more set, butconfirm_levelandyesfields, and a new function permits to retrieve this answerOpamCoreConfig.answer(lazy).One side effect of this mechanism is that if
OPAMCONFIRMLEVELis set in the environment,--yes/--noare ignored (as confirm-level > yes/no), and it can be resset only by using--confirm-level.