Merge pull request #909 from ocaml/fix-darcs

Filter installable system dependencies correctly
ocaml · Dec 6, 2024 · f8e1b8d · f8e1b8d
2 parents 2760130 + 24c7ef0
commit f8e1b8d
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 6 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/packages/setup-ocaml/src/unix.ts b/packages/setup-ocaml/src/unix.ts
@@ -9,17 +9,22 @@ async function checkAptInstallability(packageName: string) {
     "--names-only",
     `'^${packageName}$'`,
   ]);
-  return output.stdout.length !== 0;
+  return output.stdout.length > 0;
 }
 
 async function retrieveInstallableOptionalDependencies(
   optionalDependencies: string[],
 ) {
   switch (PLATFORM) {
     case "linux": {
-      return optionalDependencies.filter(
-        async (dep) => await checkAptInstallability(dep),
-      );
+      const installableOptionalDependencies: string[] = [];
+      for (const optionalDependency of optionalDependencies) {
+        const isInstallable = await checkAptInstallability(optionalDependency);
+        if (isInstallable) {
+          installableOptionalDependencies.push(optionalDependency);
+        }
+      }
+      return installableOptionalDependencies;
     }
     default: {
       return [];