Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter installable system dependencies correctly #909

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

smorimoto
Copy link
Member

No description provided.

@smorimoto smorimoto added the bug Something isn't working label Dec 6, 2024
@smorimoto smorimoto requested a review from Copilot December 6, 2024 20:10

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (1)

packages/setup-ocaml/src/unix.ts:10

  • String quoting is inconsistent with the rest of the code. Consider using single quotes to maintain consistency.
"^${packageName}$"
Signed-off-by: Sora Morimoto <sora@morimoto.io>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no suggestions.

@smorimoto smorimoto linked an issue Dec 6, 2024 that may be closed by this pull request
@smorimoto smorimoto merged commit f8e1b8d into master Dec 6, 2024
15 checks passed
@smorimoto smorimoto deleted the fix-darcs branch December 6, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setup-ocaml fails because darcs is not available
1 participant