-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize niter
#27
Comments
I mean I would just start with plotting the globally integrated flux as a function of |
TLDR; Nice! That is very similar to what I cooked up. I did however started with a single grid point first: Synthetic example for single grid pointI am using our [canonical test values]( sst = np.full(shape, 290.0, order=order) We would like this quantity to be small, which means the output for
Depending on the algo,
This conclusion could however be heavily biased due to the values chosen. So next I tried to replicate this pointwise analysis for a realistic model dataset (CM2.6). Full model output
I basically calculated the relative iteration error like above for every point in space and time. To summarize the relative iteration error, I opted for a high quartile along x,y, and time. Basically what this is showing is when 'most' of the grid cells have converged to a low relative iteration error. This is a relatively strict criterion, but as you can see in the notebook the relative iteration error is actually very spatially dependent.
The results suggest that we should chose a slightly higher Very keen on comments on this methodology. I think ultimately this would be a section of the Supp Materials for any paper resulting from this work. |
This is great work! Let's set |
Based on the work in ocean-transport/scale-aware-air-sea#27 we decided to set the default value to 6.
Closing since this seems to be solved for now! |
One of the question that came up in our sprint planning was what value we should choose for the iteration parameter
niter
in our work.The values used in aerobulk vary: I found
niter=10
in the examples while the default value is apparently 4.I will start to investigate how the performance of the algorithm scales with
niter
, but we will also have to discuss how we judge whether the values have 'converged'. I suspect that this will to some degree depend on the location and combination.Do people have suggestions how to do this?
The text was updated successfully, but these errors were encountered: