Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To automate Region and Zone labels #163

Merged
merged 1 commit into from
May 31, 2022
Merged

To automate Region and Zone labels #163

merged 1 commit into from
May 31, 2022

Conversation

aishwaryabk
Copy link
Collaborator

Signed-off-by: Aishwarya Kamat aishwarya.kamat@ibm.com

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 20, 2022
@aishwaryabk aishwaryabk mentioned this pull request May 20, 2022
Closed
@yussufsh
Copy link
Contributor

Please create an issue to track the changes. Also I have a comment which should have been tracked in the issue.
this feature should be optional. When details are not given we should just not label the nodes. This also achives backward compatibility

@aishwaryabk
Copy link
Collaborator Author

Please create an issue to track the changes. Also I have a comment which should have been tracked in the issue. this feature should be optional. When details are not given we should just not label the nodes. This also achives backward compatibility

I have created an issue on PowerVS - ocp-power-automation/ocp4-upi-powervs#418
Should I also create one in the Playbooks repo?

@yussufsh
Copy link
Contributor

It should be that way, powervs change will only include passing the region details. That is not true for powervm.
My main concern is as this playbook is used by other projects making it compulsory will not work when someone will update the hash there.

@aishwaryabk
Copy link
Collaborator Author

Created a new issue - #164

@ppc64le-cloud-bot ppc64le-cloud-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 23, 2022
@aishwaryabk
Copy link
Collaborator Author

Updated the changes.

@yussufsh yussufsh mentioned this pull request May 25, 2022
Closed
@aishwaryabk aishwaryabk force-pushed the node-label-new branch 2 times, most recently from 39369eb to 5c0ea0f Compare May 27, 2022 06:15
@ppc64le-cloud-bot ppc64le-cloud-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 27, 2022
@aishwaryabk
To automate Node Labels for PowerVS
0051f32 
Signed-off-by: Aishwarya Kamat <aishwarya.kamat@ibm.com>
yussufsh
yussufsh approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/cc @Prajyot-Parab @cs-zhang @sajauddin

@ppc64le-cloud-bot ppc64le-cloud-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 31, 2022
Prajyot-Parab
Prajyot-Parab approved these changes May 31, 2022
View reviewed changes
Copy link
Collaborator

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@ppc64le-cloud-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aishwaryabk, Prajyot-Parab, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot merged commit 7778789 into ocp-power-automation:master May 31, 2022
@yussufsh yussufsh linked an issue May 31, 2022 that may be closed by this pull request
Automate Setting Node Labels for PowerVS #164
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prajyot-Parab Prajyot-Parab Prajyot-Parab approved these changes

@yussufsh yussufsh yussufsh approved these changes

@mkumatag mkumatag Awaiting requested review from mkumatag

@cs-zhang cs-zhang Awaiting requested review from cs-zhang

@sajauddin sajauddin Awaiting requested review from sajauddin

Assignees

@yussufsh yussufsh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automate Setting Node Labels for PowerVS
4 participants
@aishwaryabk @yussufsh @ppc64le-cloud-bot @Prajyot-Parab