-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate Setting Node Labels #418
Comments
Raised PR: ocp-power-automation/ocp4-playbooks#163 |
@aishwaryabk Node labels should be a map variable so that user can add more labels in future without much or no code changes. I see in the PR you have hardcoded the labels. |
aishwaryabk
added a commit
to aishwaryabk/ocp4-upi-powervs
that referenced
this issue
May 31, 2022
Fixes: ocp-power-automation#418 Signed-off-by: Aishwarya Kamat <aishwarya.kamat@ibm.com>
Merged
@yussufsh Should we automate the 3 labels (zone, region & instance-type) and then add more custom labels via |
aishwaryabk
added a commit
to aishwaryabk/ocp4-upi-powervs
that referenced
this issue
Jun 7, 2022
Fixes: ocp-power-automation#418 Signed-off-by: Aishwarya Kamat <aishwarya.kamat@ibm.com>
aishwaryabk
added a commit
to aishwaryabk/ocp4-upi-powervs
that referenced
this issue
Jun 7, 2022
Fixes: ocp-power-automation#418 Signed-off-by: Aishwarya Kamat <aishwarya.kamat@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As per the discussion on slack (https://ibm-systems-power.slack.com/archives/CLB0VTQF5/p1652797047535559):
There are some well-known k8s labels that the RHACM UI uses (failure-domain.beta.kubernetes.io/region, failure-domain.beta.kubernetes.io/zone, and beta.kubernetes.io/instance-type) that could be set using values from the Terraform var.tfvars file.
According to the docs:
https://kubernetes.io/docs/reference/labels-annotations-taints/#topologykubernetesioregion
Ref:
https://ibm-systems-power.slack.com/archives/C01JKQWLK7X/p1652794487832839
The text was updated successfully, but these errors were encountered: