Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

installs oauthlib=3.2.0 python pkg #167

Merged
merged 1 commit into from
Jul 19, 2022
Merged

installs oauthlib=3.2.0 python pkg #167

merged 1 commit into from
Jul 19, 2022

Conversation

sajauddin
Copy link
Collaborator

To fix ImportError for SIGNATURE_RSA from oauthlib.oauth1 (python module) observed while working with centos9-stream. This issue was observed in both master and worker nodes

@ppc64le-cloud-bot ppc64le-cloud-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/non-mergeable labels Jul 7, 2022
yussufsh
yussufsh approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 13, 2022
@yussufsh yussufsh removed the request for review from mkumatag July 13, 2022 09:46
@yussufsh
Copy link
Contributor

To fix ImportError for SIGNATURE_RSA from oauthlib.oauth1 (python module) observed while working with centos9-stream. This issue was observed in both master and worker nodes

How centos-9 issue related to master/worker nodes?

@yussufsh yussufsh mentioned this pull request Jul 13, 2022
Closed
Prajyot-Parab
Prajyot-Parab previously approved these changes Jul 14, 2022
View reviewed changes
Copy link
Collaborator

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@Prajyot-Parab Prajyot-Parab self-requested a review July 14, 2022 19:45
@Prajyot-Parab Prajyot-Parab dismissed their stale review July 14, 2022 19:47

waiting for confirmation from Yussuf

@yussufsh
Copy link
Contributor

@sajauddin we this change is not needed right?

@sajauddin
Copy link
Collaborator Author

sajauddin commented Jul 19, 2022 •
edited
Loading

@yussufsh
These changes are required.
I have tried deploying OCP on PowerVS without this and it failed. Attaching the failure log for reference.
failure log.docx
.

cs-zhang
cs-zhang approved these changes Jul 19, 2022
View reviewed changes
Copy link
Collaborator

@cs-zhang cs-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cs-zhang, Prajyot-Parab, sajauddin, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot merged commit 5c39175 into ocp-power-automation:master Jul 19, 2022
@yussufsh
Copy link
Contributor

@yussufsh These changes are required. I have tried deploying OCP on PowerVS without this and it failed. Attaching the failure log for reference. failure log.docx .

Ok.. The log mentions that the error is because of kubernetes package dependency. So, this change make sense here.
Thanks @sajauddin for the contribution.

@sajauddin sajauddin deleted the centos9-changes branch November 14, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cs-zhang cs-zhang cs-zhang approved these changes

@yussufsh yussufsh yussufsh approved these changes

@Prajyot-Parab Prajyot-Parab Awaiting requested review from Prajyot-Parab

Assignees

@yussufsh yussufsh

@cs-zhang cs-zhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sajauddin @yussufsh @ppc64le-cloud-bot @cs-zhang @Prajyot-Parab