Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issues with Centos9-Stream #435

Closed

Conversation

sajauddin
Copy link
Collaborator

To fix ImportError for SIGNATURE_RSA from oauthlib.oauth1 (python module) observed while working with centos9-stream. This issue was observed in bastion, master and worker nodes. So, relevant changes required in ocp4-helpernode and ocp4-playbooks.

…rking with centos9-stream

Signed-off-by: sajauddin <sajauddin.mohammad@ibm.com>
@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sajauddin
To complete the pull request process, please assign yussufsh after the PR has been reviewed.
You can assign the PR to them by writing /assign @yussufsh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 7, 2022
@sajauddin sajauddin requested review from yussufsh, cs-zhang and Prajyot-Parab and removed request for sudeeshjohn and rpsene July 7, 2022 05:39
@ppc64le-cloud-bot
Copy link
Contributor

ppc64le-cloud-bot commented Jul 7, 2022

@sajauddin: PR is not mergeable.

The PR state is: blocked

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -148,6 +148,7 @@ sudo hostnamectl set-hostname --static ${lower(var.name_prefix)}bastion-${count.
echo 'HOSTNAME=${lower(var.name_prefix)}bastion-${count.index}.${var.cluster_domain}' | sudo tee -a /etc/sysconfig/network > /dev/null
sudo hostname -F /etc/hostname
echo 'vm.max_map_count = 262144' | sudo tee --append /etc/sysctl.conf > /dev/null
pip install oauthlib==3.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good place for this line is at resource bastion_packages as it will need python installed.

@yussufsh
Copy link
Contributor

@sajauddin I see ocp-power-automation/ocp4-playbooks#167 as well which is installed on bastion.

Copy link
Collaborator

@cs-zhang cs-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the package has installed in ocp4-playbooks, so no need to add here.

@yussufsh
Copy link
Contributor

The error was due to kubernetes package dependency while using the playbook after install hence the playbook changes make sense.

@yussufsh yussufsh closed this Jul 19, 2022
@sajauddin sajauddin deleted the centos9-changes branch July 20, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/non-mergeable size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants