Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request for VNIC failover #200

Closed
torwen1 opened this issue Apr 12, 2021 · 1 comment
Closed

Feature request for VNIC failover #200

torwen1 opened this issue Apr 12, 2021 · 1 comment

Comments

@torwen1
Copy link
Contributor

torwen1 commented Apr 12, 2021

Hi team,

I'd like to request a new feature for VNIC failover. At this point in time, your TF scripts are able to generate VNIC, but without failover.

It would be great, if we could define the number of failover/backup adapters of VNIC failover. For this we would need an additional parameter in var.tfvars and a change in network.tf.

The parameter
"vnic_required_vfs": 1,
defines how many virtual functions shall be used. If you set it to 2+, it will create VNIC failover.
Be ware, that some Linux distributions don't support VNIC failover with more than 2 virtual functions. So, a warning should be made in the documentation and var.tfvars file.
torwen1 added a commit to torwen1/ocp4-upi-powervm that referenced this issue Jul 1, 2021
@torwen1
Implementation for ocp-power-automation#200
a828123 
This is a suggestion for the implementation of ocp-power-automation#200

I already implemented exactly this code at a customer. It introduces two new variables to var.tfvars to control how many logical ports shall be used for VNIC failover and also to define the capacity of the logical ports.

Signed-off-by: Torsten Wendland <twendlan@de.ibm.com>
@torwen1 torwen1 mentioned this issue Jul 1, 2021
Closed
torwen1 added a commit to torwen1/ocp4-upi-powervm that referenced this issue Jul 1, 2021
@torwen1
Implementation for ocp-power-automation#200
44f4e42 
This is a suggestion for the implementation of ocp-power-automation#200

I already implemented exactly this code at a customer. It introduces two new variables to var.tfvars to control how many logical ports shall be used for VNIC failover and also to define the capacity of the logical ports.

Signed-off-by: Torsten Wendland <twendlan@de.ibm.com>
torwen1 added a commit to torwen1/ocp4-upi-powervm that referenced this issue Jul 1, 2021
@torwen1
Merge branch 'Implementation-for-ocp-power-automation#200' of https:/…
cafb420 
…/github.com/torwen1/ocp4-upi-powervm into Implementation-for-ocp-power-automation#200
torwen1 added a commit to torwen1/ocp4-upi-powervm that referenced this issue Jul 1, 2021
@torwen1
Implementation for ocp-power-automation#200
9dcef24 
This is a suggestion for the implementation of ocp-power-automation#200

I already implemented exactly this code at a customer. It introduces two new variables to var.tfvars to control how many logical ports shall be used for VNIC failover and also to define the capacity of the logical ports.

Signed-off-by: Torsten Wendland <twendlan@de.ibm.com>
@torwen1 torwen1 mentioned this issue Jul 1, 2021
Merged
torwen1 added a commit to torwen1/ocp4-upi-powervm that referenced this issue Jul 2, 2021
@torwen1
Implementation for ocp-power-automation#200
02f3018 
This is a suggestion for the implementation of ocp-power-automation#200

I already implemented exactly this code at a customer. It introduces two new variables to var.tfvars to control how many logical ports shall be used for VNIC failover and also to define the capacity of the logical ports.

Signed-off-by: Torsten Wendland <twendlan@de.ibm.com>
torwen1 added a commit to torwen1/ocp4-upi-powervm that referenced this issue Jul 2, 2021
@torwen1
Implementation for ocp-power-automation#200
6ec2db0 
This is a suggestion for the implementation of ocp-power-automation#200

I already implemented exactly this code at a customer. It introduces two new variables to var.tfvars to control how many logical ports shall be used for VNIC failover and also to define the capacity of the logical ports.

Signed-off-by: Torsten Wendland <twendlan@de.ibm.com>

PS:
Added validation of number of VFs, updated documentation with min and max, changed variable name from sriov_vnic_failover_adapter to sriov_vnic_failover_vfs (because we don't define amount of adapters, we are defining amount of virtual functions; adapters might mislead the user)
torwen1 added a commit to torwen1/ocp4-upi-powervm that referenced this issue Jul 2, 2021
@torwen1
Implementation for ocp-power-automation#200
5b714fb 
This is a suggestion for the implementation of ocp-power-automation#200

I already implemented exactly this code at a customer. It introduces two new variables to var.tfvars to control how many logical ports shall be used for VNIC failover and also to define the capacity of the logical ports.

Signed-off-by: Torsten Wendland <twendlan@de.ibm.com>

PS:
Added validation of number of VFs, updated documentation with min and max, changed variable name from sriov_vnic_failover_adapter to sriov_vnic_failover_vfs (because we don't define amount of adapters, we are defining amount of virtual functions; adapters might mislead the user)
ppc64le-cloud-bot pushed a commit that referenced this issue Jul 2, 2021
Merge pull request #215 from torwen1/Implemenation-for-#200.2
fff1125 
Implementation for #200
@torwen1
Copy link
Contributor Author

torwen1 commented Jul 5, 2021

Has been implemented with pull request #215

@torwen1 torwen1 closed this as completed Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@torwen1