-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation for #200 #214
Implementation for #200 #214
Conversation
This is a suggestion for the implementation of ocp-power-automation#200 I already implemented exactly this code at a customer. It introduces two new variables to var.tfvars to control how many logical ports shall be used for VNIC failover and also to define the capacity of the logical ports. Signed-off-by: Torsten Wendland <twendlan@de.ibm.com>
Added the file by mistake
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: torwen1 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @torwen1! It looks like this is your first PR to ocp-power-automation/ocp4-upi-powervm 🎉 |
Hi @torwen1. Thanks for your PR. I'm waiting for a ocp-power-automation member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@torwen1 Thanks for the PR, can you please squash commits into a single one. |
Added 3 min wait for the drain command to complete. This will help when no worker nodes are left for scheduling non disruptive pods. Fixes ocp-power-automation#203 Signed-off-by: Yussuf Shaikh <yussuf.shaikh@ibm.com>
Signed-off-by: CS Zhang <zhangcho@us.ibm.com>
Signed-off-by: CS Zhang <zhangcho@us.ibm.com>
This is a suggestion for the implementation of ocp-power-automation#200 I already implemented exactly this code at a customer. It introduces two new variables to var.tfvars to control how many logical ports shall be used for VNIC failover and also to define the capacity of the logical ports. Signed-off-by: Torsten Wendland <twendlan@de.ibm.com>
@torwen1: Adding label Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Will cancel the PR because did something wrong during squash the commits. Will cleanup my fork and open a new one. |
This is a suggestion for the implementation of #200
I already implemented exactly this code at a customer. It introduces two new variables to var.tfvars to control how many logical ports shall be used for VNIC failover and also to define the capacity of the logical ports.