Skip to content

Commit

Permalink
Adding tls.certificate.sans array, deprecate tls.sans array (#1325)
Browse files Browse the repository at this point in the history
#### Description of changes:
Notable from Tenzir on tls.sans: "This is actually a schema bug.
The SAN array should be part of the certificate object in theory, as
it's part of the cert."

---------

Signed-off-by: JW-Corelight <jeremy.wiley@corelight.com>
  • Loading branch information
JW-Corelight authored Jan 28, 2025
1 parent 3827752 commit 95d93ff
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 2 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,7 @@ Thankyou! -->
1. Added `ancestry` to the `process` object. #1317
1. Added `internal_name` to the `file` object. #1322
1. Added `cc_mailboxes`, `from_mailbox`, `to_mailboxes`, `delivered_to_list` and `reply_to_mailboxes` to `email` object. #1307
1. Added `sans` array to `certificate` object. #1325

### Bugfixes
1. Added sibling definition to `confidence_id` in dictionary, accurately associating `confidence` as its sibling. #1180
Expand All @@ -211,6 +212,7 @@ Thankyou! -->
1. Deprecated `policy` in favor of `policies` in `Account Change` class. #1282
1. Deprecated `lineage` in the `process` object. #1317
1. Deprecated `smtp_hello`, `smtp_from`, `smtp_to`, `delivered_to` and `reply_to` in favor of `command`, `from`, `to`, `delivered_to_list` and `reply_to_mailboxes` respectively. #1307
1. Deprecated `tls.sans` array in favor of added `tls.certificate.sans` array. #1325

### Misc
1. Added `user.uid` as an Observable type - `type_id: 31`. #1155
Expand Down
7 changes: 6 additions & 1 deletion objects/certificate.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,11 @@
"is_self_signed": {
"requirement": "recommended"
},
"sans": {
"description": "The list of subject alternative names that are secured by a specific certificate.",
"caption": "Subject Alternative Names",
"requirement": "optional"
},
"serial_number": {
"description": "The serial number of the certificate used to create the digital signature.",
"caption": "Certificate Serial Number",
Expand All @@ -44,4 +49,4 @@
"requirement": "recommended"
}
}
}
}
6 changes: 5 additions & 1 deletion objects/tls.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@
"requirement": "optional"
},
"sans": {
"@deprecated": {
"message": "Use <code>tls.certificate.sans</code> attribute instead.",
"since": "1.4.0"
},
"requirement": "optional"
},
"server_ciphers": {
Expand All @@ -51,4 +55,4 @@
"requirement": "required"
}
}
}
}

0 comments on commit 95d93ff

Please sign in to comment.