Adding tls.certificate.sans array, deprecate tls.sans array #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notable from Tenzir on tls.sans: "This is actually a schema bug. The SAN array should be part of the certificate object in theory, as it's part of the cert." Signed-off-by: JW-Corelight <jeremy.wiley@corelight.com>
Notable from Tenzir: "This is actually a schema bug. The SAN array should be part of the certificate object in theory, as it's part of the cert." Signed-off-by: JW-Corelight <jeremy.wiley@corelight.com>
JW-Corelight
requested review from
floydtree,
pagbabian-splunk,
Aniak5,
mikeradka,
zschmerber,
jonrau-at-queryai and
davemcatcisco
as code owners
JW-Corelight
changed the title
floydtree
previously requested changes
Jan 27, 2025
There was a problem hiding this comment.
Good to get this in for 1.4.0 release.
@JW-Corelight Can you update the Changelog to reflect the changes in this PR? The PR template should guide you to do so.
Signed-off-by: JW-Corelight <jeremy.wiley@corelight.com>
floydtree
previously requested changes
Jan 27, 2025
Signed-off-by: JW-Corelight <jeremy.wiley@corelight.com>
JW-Corelight
dismissed
floydtree’s stale review
Updated as requested - I'm learning fast, thanks rajas!
zschmerber
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Notable from Tenzir on tls.sans: "This is actually a schema bug.
The SAN array should be part of the certificate object in theory, as it's part of the cert."