Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add url attribute to file object #1291

Closed
rmouritzen-splunk opened this issue Dec 18, 2024 · 1 comment
Closed

Add url attribute to file object #1291

rmouritzen-splunk opened this issue Dec 18, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request non_breaking Non Breaking, backwards compatible changes v1.4.0 Changes marked for the upcoming version 1.4.0

Comments

@rmouritzen-splunk
Copy link
Contributor

Summary

Add url as an optional attribute in the file object.

Reasoning

The File Hosting Activity (6006) event class has no place to capture the URL of a file.

@zschmerber Hit this while creating OCSF events for Slack message that may include a file by URL in Network File Activity (4010 -- deprecated in favor of File Hosting Activity).

Email Activity (4009) has a similar issue.

We now have 2 (or more) situations where a url attribute inside the file object so it seems clear this is where the URL for File Hosting Activity should belong.

cc: @mikeradka

@rmouritzen-splunk rmouritzen-splunk changed the title Add url attribute to file object Add url attribute to file object Dec 18, 2024
@rmouritzen-splunk rmouritzen-splunk self-assigned this Dec 18, 2024
@mikeradka
Copy link
Contributor

Some extra context - we discussed this a bit in the 12/18/2024 system call and the group concluded that adding a url attribute to the file object would be a valuable addition.

@rmouritzen-splunk rmouritzen-splunk added enhancement New feature or request non_breaking Non Breaking, backwards compatible changes v1.4.0 Changes marked for the upcoming version 1.4.0 labels Dec 18, 2024
rmouritzen-splunk added a commit to rmouritzen-splunk/ocsf-schema that referenced this issue Dec 23, 2024
jonrau-at-queryai added a commit that referenced this issue Jan 6, 2025
#### Related Issue: 
#1291

#### Description of changes:
Add `url` attribute to `file` object. See related issue for details.

### Delete once you have confirmed the following: 
1. Did you add a single line summary of changes to `Unreleased` section
in the
[CHANGELOG.md](https://github.com/ocsf/ocsf-schema/blob/main/CHANGELOG.md)
file?
TBD

Co-authored-by: Jonathan Rau <139361268+jonrau-at-queryai@users.noreply.github.com>
jonrau-at-queryai pushed a commit that referenced this issue Jan 14, 2025
…c… (#1315)

#### Related Issue: 
#1296

#### Description of changes:
The existing File Hosting Activity class has attributes added to cover
the file sharing access check case. A new "Access Check" Activity ID is
added, and optional group context attributes are added..

This PR include a line in `CHANGELIST.md` for PR
#1291, which was merged before
the `CHANGELOG.md` was updated.

NOTE: This PR replaces #1297,
which was closed as it got mess up somehow.

---------

Signed-off-by: Ania Kacewicz <ania.kacewicz@gmail.com>
Co-authored-by: Ania Kacewicz <ania.kacewicz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request non_breaking Non Breaking, backwards compatible changes v1.4.0 Changes marked for the upcoming version 1.4.0
Projects
None yet
Development

No branches or pull requests

3 participants