Add attributes to File Hosting Activity for the file share access chec… #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmouritzen-splunk
requested review from
floydtree,
pagbabian-splunk,
Aniak5,
mikeradka,
zschmerber,
jonrau-at-queryai and
davemcatcisco
as code owners
rmouritzen-splunk
added
enhancement
zschmerber
previously approved these changes
Jan 14, 2025
Signed-off-by: Ania Kacewicz <ania.kacewicz@gmail.com>
Aniak5
dismissed stale reviews from zschmerber, jonrau-at-queryai, and themself
via
d94f514
floydtree
approved these changes
Jan 14, 2025
rmouritzen-splunk
changed the title
zschmerber
approved these changes
Jan 14, 2025
jonrau-at-queryai
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue:
#1296
Description of changes:
The existing File Hosting Activity class has attributes added to cover the file sharing access check case. A new "Access Check" Activity ID is added, and optional group context attributes are added..
This PR include a line in
CHANGELIST.mdfor PR #1291, which was merged before theCHANGELOG.mdwas updated.NOTE: This PR replaces #1297, which was closed as it got mess up somehow.