Add ?cloexec:bool argument to wrapped Unix functions in Lwt_unix
#901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Lwt_unix module, add `?cloexec:bool` optional arguments to functions that create file descriptors (`dup`, `dup2`, `pipe`, `pipe_in`, `pipe_out`, `socket`, `socketpair`, `accept`, `accept_n`). The `?cloexec` argument is simply forwarded to the wrapped Unix function (with OCaml >= 4.05, see [ocaml/ocaml#650][650]), or emulated as best-effort with `Unix.set_close_on_exec` on older OCaml versions. Fix ocsigen#327. Fix ocsigen#847. See also ocsigen#872. [650]: ocaml/ocaml#650
smorimoto
approved these changes
Nov 11, 2021
|
At least this looks good to me. @raphael-proust Could you confirm this as well? |
|
This looks ok to me as well. |
raphael-proust
approved these changes
Nov 18, 2021
|
Thanks @MisterDA! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Lwt_unix module, add
?cloexec:booloptional arguments tofunctions that create file descriptors (
dup,dup2,pipe,pipe_in,pipe_out,socket,socketpair,accept,accept_n).The
?cloexecargument is simply forwarded to the wrapped Unixfunction (with OCaml >= 4.05, see ocaml/ocaml#650), or emulated
as best-effort with
Unix.set_close_on_execon older OCaml versions.Fix #327. Fix #847. See also #872.