Docker backend #75
Closed
Docker backend #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talex5
reviewed
Jul 5, 2021
|
Thinking on about this... the Build module creates a builder from a store and a sandbox. That will work on Linux (runc+btrfs), mac (users+zfs) and probably on FreeBSD (jails+zfs). But it doesn't work with Docker, because Docker already combines a store and a sandbox. So probably this should be an alternative to the build.ml module instead. |
|
Thanks for the review, I agree with your conclusion and will refactor the code to merge the Docker sandbox, A note regarding the use of the Docker Engine API: I wanted to replace the process calls to the
I'm putting this on hold for now, and I'll stay with the docker client until openapi-generator is fixed. |
MisterDA
force-pushed
the
docker
branch
4 times, most recently
from
52288a1
to
da98be5
Compare
MisterDA
force-pushed
the
docker
branch
9 times, most recently
from
fdaea39
to
1920afa
Compare
MisterDA
force-pushed
the
docker
branch
11 times, most recently
from
c8729ea
to
68e9084
Compare
1 task
7 tasks
Otherwise embedded text get crlf line endings.
Mounts are read-write to preserve current behaviour.
This allows to specify the entrypoint of a `Sandbox.run job`. This is only needed for the Docker sandbox, to override the Docker image entrypoint.
Granted, it's more difficult to read, but way easier to copy-paste to inspect manually what's happening.
This prevents errors on Windows where a file cannot be renamed, moved or deleted if it is open by another process. It also ensure that the database is left in a clean state.
…q-cmdliner', 'MisterDA/docker-windows-spec' and 'MisterDA/docker-windows-prerequisites' into docker
Checking the result for the Docker backend requires asynchronous calls to Docker.
With the Docker backend on Windows, it's easier to store logs in a location where they're not moved, as a directory cannot be renamed if it contains open file descriptors. For the btrfs and zfs backends, the original location is retained.
|
I lost the race to merge before macOS. The rebase wasn't easy, I've probably broken one or two new things in my code. |
benmandrew
added a commit
to benmandrew/opam-repository
that referenced
this pull request
Jan 31, 2024
CHANGES: - Add a Docker backend for Windows and Linux jobs. (@MisterDA ocurrent/obuilder#127 ocurrent/obuilder#75, reviewed by @talex5 and @tmcgilchrist) - Add FreeBSD sandbox backend using jail(8) (@dustanddreams ocurrent/obuilder#156 ocurrent/obuilder#174, reviewed by @tmcgilchrist, @MisterDA, and @mtelvers) - Add Macos ZFS sandbox (@mtelvers ocurrent/obuilder#164, reviewed by @tmcgilchrist) - Support XFS store (@mtelvers ocurrent/obuilder#170, reviewed by @tmcgilchrist) - Search for bash rather than assume it lies in /bin (@dustanddreams ocurrent/obuilder#159, reviewed by @tmcgilchrist) - Prune builds one at a time up to the limit (@mtelvers ocurrent/obuilder#157) - Specify upper bound on number of items in the store (@mtelvers ocurrent/obuilder#158, reviewed by @MisterDA) - Fix case where BTRFS is not fully allocated (@mtelvers ocurrent/obuilder#162) - Avoid pruning parent cache objects (@mtelvers ocurrent/obuilder#176, reviewed by @tmcgilchrist)
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
CHANGES: - Add a Docker backend for Windows and Linux jobs. (@MisterDA ocurrent/obuilder#127 ocurrent/obuilder#75, reviewed by @talex5 and @tmcgilchrist) - Add FreeBSD sandbox backend using jail(8) (@dustanddreams ocurrent/obuilder#156 ocurrent/obuilder#174, reviewed by @tmcgilchrist, @MisterDA, and @mtelvers) - Add Macos ZFS sandbox (@mtelvers ocurrent/obuilder#164, reviewed by @tmcgilchrist) - Support XFS store (@mtelvers ocurrent/obuilder#170, reviewed by @tmcgilchrist) - Search for bash rather than assume it lies in /bin (@dustanddreams ocurrent/obuilder#159, reviewed by @tmcgilchrist) - Prune builds one at a time up to the limit (@mtelvers ocurrent/obuilder#157) - Specify upper bound on number of items in the store (@mtelvers ocurrent/obuilder#158, reviewed by @MisterDA) - Fix case where BTRFS is not fully allocated (@mtelvers ocurrent/obuilder#162) - Avoid pruning parent cache objects (@mtelvers ocurrent/obuilder#176, reviewed by @tmcgilchrist)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the Docker backend for OBuilder. It should support running on Windows with Docker for Windows, and on Linux with the usual Docker.
This PR contains a batch of prerequisites, and then the backend.
I have tested it on Windows and Linux, on basic examples.
is_blockingindupanddup2to fixENOTSOCKon Windows ocsigen/lwt#869?cloexec:boolargument to wrappedUnixfunctions inLwt_unixocsigen/lwt#901