Failing tests for GetAllContentsByRef on a branch with a root path

[SimonCropp]

the "/" seems to force it back to the master branch. just wondering if this is by design?

[shiftkey]

The URL that gets generated in here looks like this:

octokit.net/Octokit/Helpers/ApiUrls.cs

Lines 2353 to 2356 in d16ac98

	public static Uri RepositoryContent(string owner, string name, string path, string reference)
	{
	return "repos/{0}/{1}/contents/{2}?ref={3}".FormatUri(owner, name, path, reference);
	}

I wonder if the "/" here is causing the confusing URL. @SimonCropp what happens if you make this an empty string?

[SimonCropp]

null and empty string throw an arg exception. https://github.com/octokit/octokit.net/blob/master/Octokit/Clients/RepositoryContentsClient.cs#L103

happy to attempt a PR where either null or empty string mean "root dir"

[ryangribble]

I'm on mobile at the moment but I think there is another overload that doesn't take a path, which you can use when you want the root

[SimonCropp]

@ryangribble yep and i am already using that workaround. although it makes for some ugly code for anyone hitting this

    static Task<IReadOnlyList<RepositoryContent>> GetAllContents(IRepositoryContentsClient content, string owner, string repo, string path, string branch)
    {
        if (branch == null)
        {
            if (path != null)
            {
                return content.GetAllContents(owner, repo, path);
            }
            return content.GetAllContents(owner, repo);
        }

        if (path != null)
        {
            return content.GetAllContentsByRef(owner, repo, path, reference: branch);
        }
        return content.GetAllContentsByRef(owner, repo, reference: branch);
    }

but ignoring that workaround. i think it is still a bug that you query for a branch and get results from master

[shiftkey]

Moving this to #2105 as the fork has been removed