Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve handling of GetAllContentsByRef where root path is requested #2105

Merged
merged 2 commits into from
Feb 24, 2020

Conversation

shiftkey
Copy link
Member

@shiftkey shiftkey commented Feb 24, 2020

Supersedes #1956

🎩@SimonCropp for the failing test

@shiftkey
Copy link
Member Author

release_notes: RepositoryContentsClient.GetAllContentsByRef handles special case where you want / as well as a different branch.

@shiftkey shiftkey merged commit 5223d1a into master Feb 24, 2020
@shiftkey shiftkey deleted the backport-failing-integration-test branch February 24, 2020 22:12
@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #2105 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2105      +/-   ##
==========================================
- Coverage   66.84%   66.83%   -0.01%     
==========================================
  Files         542      542              
  Lines       14219    14221       +2     
==========================================
  Hits         9504     9504              
- Misses       4715     4717       +2
Impacted Files Coverage Δ
Octokit/Clients/RepositoryContentsClient.cs 100% <100%> (ø) ⬆️
Octokit.Reactive/Helpers/ObservableExtensions.cs 91.26% <0%> (-1.95%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants