Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure datetime offset is encoded correctly for search APIs #2091

Merged
merged 4 commits into from
Feb 10, 2020

Conversation

shiftkey
Copy link
Member

@shiftkey shiftkey commented Feb 10, 2020

Fixes #2056

  • CI passes
  • diff makes sense

@codecov
Copy link

codecov bot commented Feb 10, 2020

Codecov Report

Merging #2091 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2091      +/-   ##
==========================================
+ Coverage   67.05%   67.05%   +<.01%     
==========================================
  Files         538      538              
  Lines       14140    14141       +1     
==========================================
+ Hits         9481     9482       +1     
  Misses       4659     4659
Impacted Files Coverage Δ
...ctokit/Models/Request/SearchRepositoriesRequest.cs 74.03% <100%> (+0.25%) ⬆️

@shiftkey shiftkey marked this pull request as ready for review February 10, 2020 01:56
@shiftkey
Copy link
Member Author

release_notes: encodes offset part of DateTimeOffset when used in Search APIs

@shiftkey shiftkey merged commit 5de3791 into master Feb 10, 2020
@shiftkey shiftkey deleted the encoding-offset-correctly branch February 10, 2020 02:13
@nickfloyd nickfloyd added Type: Bug Something isn't working as documented and removed category: bug labels Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search requests need to correctly encode offset for date values
2 participants