Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure datetime offset is encoded correctly for search APIs #2091

Merged
merged 4 commits into from
Feb 10, 2020
Merged

ensure datetime offset is encoded correctly for search APIs #2091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e10080a
add failing integration test for timestamp
shiftkey Feb 10, 2020
c238937
make the test pass by encoding the value
shiftkey Feb 10, 2020
d588812
generalize this pattern for now
shiftkey Feb 10, 2020
76102d5
update tests to reflect change in date formatting
shiftkey Feb 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion Octokit.Tests.Integration/Clients/SearchClientTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System.Collections.Generic;
using System;
using System.Collections.Generic;
using System.Linq;
using System.Threading.Tasks;
using Octokit;
Expand All @@ -23,6 +24,18 @@ public async Task SearchForCSharpRepositories()
Assert.NotEmpty(repos.Items);
}

[IntegrationTest]
public async Task SearchForCSharpRepositoriesUpdatedIn2020()
{
var request = new SearchRepositoriesRequest("csharp")
{
Updated = DateRange.GreaterThan(new DateTimeOffset(2020, 1, 1, 0, 0, 0, TimeSpan.Zero))
};
var repos = await _gitHubClient.Search.SearchRepo(request);

Assert.NotEmpty(repos.Items);
}

[IntegrationTest]
public async Task SearchForForkedRepositories()
{
Expand Down
Loading