Skip to content

Conversation

antoine162
Copy link
Contributor

task-4559158

  • Don't mention module l10n_lu_reports_annual_vat that was merged into l10n_lu_reports in saas-15.4
  • Add brief sections for taxes and for e-invoicing via Peppol
  • Simplify the monthly and annual VAT declaration sections (both have an XML export for upload to the eCDF platform)

@antoine162 antoine162 requested a review from dade-odoo October 16, 2025 15:15
@robodoo
Copy link
Collaborator

robodoo commented Oct 16, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team October 16, 2025 15:15
@antoine162
Copy link
Contributor Author

Hi @dade-odoo I'd love to have an informal chat about this task before we move on to a more formal review, but wanted to already create the PR just so I can see the CI results. 😄

@antoine162 antoine162 force-pushed the 17.0-luxembourg-fixes-4559158-andu branch 2 times, most recently from ad6d589 to 1e6ec12 Compare October 17, 2025 12:43
task-4559158

- Don't mention module `l10n_lu_reports_annual_vat` that was merged into
  `l10n_lu_reports` in saas-15.4
- Add brief sections for taxes and for e-invoicing via Peppol
- Simplify the monthly and annual VAT declaration sections (both have an
  XML export for upload to the eCDF platform)
@antoine162 antoine162 force-pushed the 17.0-luxembourg-fixes-4559158-andu branch from 1e6ec12 to 22e6c23 Compare October 17, 2025 12:50
@antoine162
Copy link
Contributor Author

@dade-odoo I think this is all ready for a more formal review 😄

Copy link
Contributor

@dade-odoo dade-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @antoine162 , thanks for a great first doc PR (as part of the content team)!
Because you're still getting used to our writing guidelines (and of course there are some that aren't explicitly spelled out on the guidelines page), I've been pretty nit-picky, but I've tried to give explanations behind them all. Please let me know if you have any questions about them - I'm happy to talk about it all.
Overall you did a great job improving this doc, and I'm sure users of the Luxembourgish localization will appreciate the update.

- :doc:`../accounting/get_started/chart_of_accounts`: a predefined set of accounts that follows the
current official accounting standards (PCN 2020)
- :ref:`localizations/luxembourg/taxes`: pre-configured tax rates, including standard (17%),
reduced (14%, 8% and 3%) and zero-rated VAT, intra-community, and zero-rated export taxes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
reduced (14%, 8% and 3%) and zero-rated VAT, intra-community, and zero-rated export taxes
reduced (14%, 8%, and 3%) and zero-rated VAT, intra-community, and zero-rated export taxes

In general I try not to nit-pick too much but I am a firm believer in the Oxford comma 😅

Comment on lines +41 to +42
- :doc:`../accounting/taxes/fiscal_positions`: automated tax adjustments based on customer or
supplier registration status
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- :doc:`../accounting/taxes/fiscal_positions`: automated tax adjustments based on customer or
supplier registration status
- :doc:`../accounting/taxes/fiscal_positions`: automated account and tax adjustments based on customer or
supplier registration status

Since you mentioned the account mapping aspect in parenthesis, let's mention it here, too.

supplier registration status
- :ref:`localizations/luxembourg/e-invoicing`: E-invoicing with Peppol
- :ref:`localizations/luxembourg/tax-reporting`: detailed overview of your VAT liability, and
generation of monthly and annual VAT declarations in XML format to upload to the eCDF platform
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
generation of monthly and annual VAT declarations in XML format to upload to the eCDF platform
generation of monthly and annual VAT declarations in XML format to upload to the :abbr:`eCDF platform (plateform électronique de Collecte des Données Financières)`

Annual tax report
=================
- standard VAT (17%): applied to most goods and services within Luxembourg
- reduced VAT (14%, 8% and 3%): applied to some goods and services within Luxembourg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- reduced VAT (14%, 8% and 3%): applied to some goods and services within Luxembourg
- reduced VAT (14%, 8%, and 3%): applied to some goods and services within Luxembourg

.. image:: luxembourg/annual-tax-report.png
:align: center
:alt: Odoo Accounting (Luxembourg localization) generates an annual tax declaration.
E-invoicing via Peppol is mandatory for all B2G transactions in Luxembourg.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
E-invoicing via Peppol is mandatory for all B2G transactions in Luxembourg.
.. important::
E-invoicing via Peppol is mandatory for all B2G transactions in Luxembourg.

Let's also move this to come after the BIS Billing 3.0 line so that we aren't splitting up two short sentences with the important note. And just as a note explaining my reasoning here, if this section were longer, the BIS Billing line could also be in a note admonition block, but it would look strange to have two admonition blocks in a section that only has three sentences total :)


FAIA (SAF-T)
============
Go to :menuselection:`Accounting --> Reporting --> Statement Reports --> Tax Report`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Go to :menuselection:`Accounting --> Reporting --> Statement Reports --> Tax Report`.
Go to :menuselection:`Accounting --> Reporting --> Tax Report`.

In menu selection markups we only list the elements that actually need to be clicked on, so we'll leave out "Statement Reports" group name. This has the benefit of not needing to be changed for the later versions where it's placed under a different group as the devs switch things around on us ;)

**FAIA (Fichier d’Audit Informatisé AED)** is a standardized and structured file that facilitates
the exchange of information between the taxpayers' accounting system and the tax office. It is the
Luxembourgish version of the OECD-recommended SAF-T (Standard Audit File for Tax).
In the :guilabel:`Report` selector, choose :guilabel:`Tax Report (LU)` to view the monthly VAT declaration, or
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In the :guilabel:`Report` selector, choose :guilabel:`Tax Report (LU)` to view the monthly VAT declaration, or
In the :icon:`fa-book` :guilabel:`Report` selector, choose :guilabel:`Tax Report (LU)` to view the monthly VAT declaration, or

Comment on lines +89 to +91
.. note:: The Annual VAT declaration comes populated with the amounts for the
**simplified annual declaration**. The fields for the **complete annual declaration** are
available to be manually filled in if needed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What fields are required for the complete annual declaration?


.. note::
This feature requires the module :guilabel:`Luxembourg - Accounting Reports` to be installed.
Once the declaration is correct, click on :guilabel:`XML` in the cog menu to export it in XML
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Once the declaration is correct, click on :guilabel:`XML` in the cog menu to export it in XML
Once the declaration is correct, click the :icon:`fa-cog` (:guilabel:`action menu`) icon, then click :guilabel:`XML` to export it in XML

Comment on lines +115 to +117
Open :menuselection:`Accounting --> Reporting --> Audit Reports --> General Ledger`, choose the
desired period, then click on :guilabel:`Export FAIA` in the cog menu to generate and download the
FAIA file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Open :menuselection:`Accounting --> Reporting --> Audit Reports --> General Ledger`, choose the
desired period, then click on :guilabel:`Export FAIA` in the cog menu to generate and download the
FAIA file.
To generate and download the FAIA file, open :menuselection:`Accounting --> Reporting --> General
Ledger`, choose the desired period, click on the :icon:`fa-cog` (:guilabel:`action menu`) and click
:guilabel:`Export FAIA`.
  1. Remove "Audit Reports" from menu selection as explained in an earlier comment
  2. When giving instructions, we try to put the desired outcome at the beginning of the sentence (i.e., to achieve X, do A, B, C). This way, readers know from the beginning of the sentence if it's something they're interested in doing or not. This isn't an ironclad rule, as sometimes the construction of the sentence would make it awkward (for example, on line 93, I left the desired outcome at the end of the sentence because the introductory phrase "Once the declaration is correct" would make it awkward to move around).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants