[FIX] composer: change mode to editing when composer cursor selection changes #7485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… changes
Before this commit:
- When typing '=sum(' and pressing the Home key, selecting a range caused weird
behavior in the composer.
- The same issue occurred when using Ctrl+A to select the entire text.
After this commit:
- Changing the cursor selection now correctly switches the mode to 'editing'.
Task: 5226615
X-original-commit: e9da932
Collaborator
|
|
Collaborator
Author
|
This PR targets saas-18.4 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Collaborator
Author
|
@rmbh-odoo @VincentSchippefilt the next pull request (#7486) is in conflict. You can merge the chain up to here by saying
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Contributor
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Nov 19, 2025
… changes
Before this commit:
- When typing '=sum(' and pressing the Home key, selecting a range caused weird
behavior in the composer.
- The same issue occurred when using Ctrl+A to select the entire text.
After this commit:
- Changing the cursor selection now correctly switches the mode to 'editing'.
closes #7485
Task: 5226615
X-original-commit: e9da932
Signed-off-by: Vincent Schippefilt (vsc) <vsc@odoo.com>
Signed-off-by: Ronakkumar Mukeshbhai Bharadiya (rmbh) <rmbh@odoo.com>
fw-bot
deleted the
saas-18.4-17.0-fix-composer-range-selection-rmbh-478305-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Current behavior before PR:
=sum(and pressing the Home key, selecting a range caused weirdbehavior in the composer.
Desired behavior after PR is merged:
Task: 5226615
review checklist
Forward-Port-Of: #7483
Forward-Port-Of: #7400