[FIX] Demo: Fix wrapper style #7556
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
Collaborator
Author
|
@rrahir @pro-odoo cherrypicking of pull request #7468 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
When we introduced the mobile mode, we started relying on the dynamic vewport height (dvh) to account for the resizing of the viewport when the virtual keyboard of a smarphone would pop up. However, the rule we chose was to set the height of spreadsheet wrapper to 100dvh, which stands for 100% of the dynamic viewport height. As such, if we were to add some header before the Spreadsheet component, the latter would keep its size as 100% of the viewport, meaning that the full component is pushed downwards and it overflows from the page. This revision places the 100dvh rule over the full page to account for any header that could be added in the future. Task: 5212448 X-original-commit: f814b30
rrahir
force-pushed
the
master-saas-18.4-fix-dynamic-size-rar-480843-fw
branch
from
8279e31 to
64a11ad
Compare
Collaborator
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Nov 28, 2025
When we introduced the mobile mode, we started relying on the dynamic vewport height (dvh) to account for the resizing of the viewport when the virtual keyboard of a smarphone would pop up. However, the rule we chose was to set the height of spreadsheet wrapper to 100dvh, which stands for 100% of the dynamic viewport height. As such, if we were to add some header before the Spreadsheet component, the latter would keep its size as 100% of the viewport, meaning that the full component is pushed downwards and it overflows from the page. This revision places the 100dvh rule over the full page to account for any header that could be added in the future. closes #7556 Task: 5212448 X-original-commit: f814b30 Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com> Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we introduced the mobile mode, we started relying on the dynamic vewport height (dvh) to account for the resizing of the viewport when the virtual keyboard of a smarphone would pop up.
However, the rule we chose was to set the height of spreadsheet wrapper to 100dvh, which stands for 100% of the dynamic viewport height. As such, if we were to add some header before the Spreadsheet component, the latter would keep its size as 100% of the viewport, meaning that the full component is pushed downwards and it overflows from the page.
This revision places the 100dvh rule over the full page to account for any header that could be added in the future.
Task: 5212448
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist
Forward-Port-Of: #7468