Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes 20240302 #3162

Conversation

Tiny-DM
Copy link

@Tiny-DM Tiny-DM commented Mar 2, 2024

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

Information:
Fixed a broken WS template missing a few brackets.
The troop training GUI will no longer close after an upgrade is purchased, making it easier if you want to buy more than 1 level at a time.
Players will be kicked out of any animations before teleport, fixing a bug with the setup stage.
Added a space in the "loaded mods" hint.
Localized a No/Yes in the Map Info hint.

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

How can the changes be tested?

Steps:


Notes:

@Tiny-DM Tiny-DM added Bug Something isn't working Change A change to existing functionality Review pending labels Mar 2, 2024
@Tiny-DM Tiny-DM added this to the 3.6 milestone Mar 2, 2024
@Tiny-DM Tiny-DM requested a review from jaj22 March 2, 2024 18:38
@Tiny-DM Tiny-DM self-assigned this Mar 2, 2024
Copy link

@jaj22 jaj22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but the switchMove should be tested in MP.

@@ -156,6 +156,7 @@ _loadoutData set ["ATLaunchers", [
["launch_MRAWS_sand_F", "", "acc_pointer_IR", "", ["MRAWS_HE_F", "MRAWS_HEAT55_F"], [], ""],
["launch_MRAWS_sand_F", "", "acc_pointer_IR", "", ["MRAWS_HEAT_F", "MRAWS_HEAT55_F"], [], ""],
["launch_MRAWS_sand_F", "", "acc_pointer_IR", "", ["MRAWS_HEAT_F", "MRAWS_HE_F"], [], ""]
]];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ante185 ante185 mentioned this pull request Mar 18, 2024
5 tasks
@Bob-Murphy Bob-Murphy merged commit 2976ac4 into official-antistasi-community:unstable Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Change A change to existing functionality Ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants