Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass controller to serialize / deserialize #50

Merged
merged 2 commits into from
Jan 19, 2018

Conversation

buschtoens
Copy link
Contributor

Closes #46.

@offirgolan
Copy link
Owner

Thanks @buschtoens! 😄

@offirgolan offirgolan merged commit 26b1f43 into offirgolan:master Jan 19, 2018
@offirgolan
Copy link
Owner

Released with v0.3.7

@Turbo87
Copy link

Turbo87 commented Mar 7, 2019

@offirgolan @buschtoens it appears that this feature is actually somewhat broken. the thing that is getting passed to the serialize/deserialize() methods is the controller prototype, not the controller instance. that means that e.g. injected services on the controller cannot be looked up and trying to look them up will throw errors.

reverting #25 might fix this, but apparently, that would cause other issues. any clues on how to solve this?

@buschtoens
Copy link
Contributor Author

Oh, dang. Unfortunately I'm not currently using ember-parachute. :/

@Turbo87
Copy link

Turbo87 commented Mar 7, 2019

seems like this issue is similar to #46 (comment) 😢

@offirgolan
Copy link
Owner

@Turbo87 one solution is to pass undefined when we don't have the controller instance. That would be a breaking change but would also be safer. We could also try to serialize/deserialize only when the controller is ready but I'm unsure on what would be the resulting behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants