Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow re-use of fi_info returned from fi_getinfo #49

Closed
shefty opened this issue Sep 3, 2014 · 3 comments
Closed

Allow re-use of fi_info returned from fi_getinfo #49

shefty opened this issue Sep 3, 2014 · 3 comments
Assignees
@shefty
Labels
enhancement
Milestone
alpha release

Comments

@shefty
Copy link
Member

shefty commented Sep 3, 2014

The struct fi_info returned from fi_getinto may only be used once. Redefine the API to allow the fi_info to be used multiple times. This will require changes from the verbs provider to handle the 'data' field differently. Note that the data field is also used when establishing a connection request.
@shefty shefty added this to the alpha release milestone Sep 3, 2014
@shefty
Copy link
Member Author

shefty commented Sep 18, 2014

A possible solution is for the FI_CONNREQ event to return a connection 'context' to the application. The context is in the fi_eq_cm_entry structure. (part of fi_eq_entry header). This context can be provided as input into cm::accept or reject. The drawback is that the EP will be created and enabled without knowing that it will be associated with the connection. This seems doable, though it may require software to track the EP creation and configuration until accept is called.

This approach could eliminate the data field from fi_info.

This was referenced Sep 18, 2014
Closed
Closed
@shefty
Copy link
Member Author

shefty commented Sep 19, 2014

This change should remove the provider specific freeinfo call.

@shefty shefty self-assigned this Oct 2, 2014
@shefty
Copy link
Member Author

shefty commented Oct 2, 2014

Addressed in commit 6b0bbb7

@shefty shefty closed this as completed Oct 2, 2014
aingerson referenced this issue in aingerson/libfabric Jan 25, 2017
@shefty
Merge pull request #49 from rfaucett/eq_test
2565634 
add EQ unit test "unit/fi_eq_test"
jswaro added a commit that referenced this issue Nov 27, 2018
@jswaro
Merge pull request #49 from jswaro/feature/xrc-sft-testing
771cf35 
contrib/cray: Add XRC testing with SFT
@zhngaj zhngaj mentioned this issue Feb 21, 2020
Closed
tstruk pushed a commit to tstruk/libfabric that referenced this issue Oct 7, 2024
@BKitor @epilmore
Merged in LEX-4099-fi_mr_reg-fails-on-bad-mr-error (pull request ofiw…
e27b09d 
…g#49)

LEX-4099 - Fix bad error check in fi_mr_reg

* LEX-4099 - Fix bad error check in fi_mr_reg

Fix bad error check in fi_mr_reg, and add more logging

Signed-off-by: Benjamin Kitor <bkitor@gigaio.com>


Approved-by: Tadeusz Struk
Approved-by: Eric Pilmore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shefty shefty

Labels
enhancement
Projects
None yet
Milestone
alpha release
Development

No branches or pull requests
1 participant
@shefty