Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove config TwoPhotonSeries name. Save edit roi status in nwb file. #473

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

emuemuJP
Copy link
Collaborator

No description provided.

@emuemuJP emuemuJP requested a review from ShogoAkiyama April 20, 2023 13:37
@emuemuJP emuemuJP marked this pull request as ready for review April 20, 2023 13:54
@emuemuJP emuemuJP merged commit 13ad346 into develop-main Apr 24, 2023
@@ -1,33 +1,44 @@
import numpy as np
import os
from optinist.api.dataclass.dataclass import *
from .utils import get_im, get_stat0_add_roi, masks_and_traces, save_json_data
from .utils import get_stat0_add_roi, masks_and_traces, save_json_data
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

絶対パスにしたい

@@ -1,39 +1,47 @@
import numpy as np
from optinist.api.dataclass.dataclass import *
from .utils import get_im, save_json_data
from .utils import save_json_data
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

今のうちに絶対パスに直したい

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#460 で対応できればと思います

stat_orig = np.concatenate((stat_orig, np.array([stat0])), axis=0)
iscell = np.append(iscell, [True])
stat_orig = roi_stats(stat_orig, d0[0], d0[1], ly, lx)
print(type(stat_orig), type(stat0), type(stat_orig[0]))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

デバッグ用は消した方がいいかも

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

消し損ねてましたw

im = np.concatenate((im, array), axis=0)
im[im == 0] = np.nan

print(merge_roi)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

デバッグ用は消した方がいいかも

quanpython pushed a commit that referenced this pull request Jun 28, 2023
Remove config TwoPhotonSeries name. Save edit roi status in nwb file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants