feat: remove value field from token - OKTA-338251 (#515)

okta · Apr 2, 2021 · 33ac9d1 · 33ac9d1
1 parent 9ee3cf9
commit 33ac9d1
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 12 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## 5.0.0
+
+### Other
+
+- [#515](https://github.com/okta/okta-auth-js/pull/515) Removes `token.value` field
+
 ## 4.9.0
 
 ### Bug Fixes
@@ -25,7 +31,6 @@
 - [#648](https://github.com/okta/okta-auth-js/pull/648) Updates widget to 5.4.2
 - [#653](https://github.com/okta/okta-auth-js/pull/653) Removes isLoginRedirect check in oidc logic
 - [#661](https://github.com/okta/okta-auth-js/pull/661) Upgrades node-cache to 5.1.2
-
 ## 4.7.2
 
 ### Bug Fixes

diff --git a/lib/oidc/handleOAuthResponse.ts b/lib/oidc/handleOAuthResponse.ts
@@ -85,7 +85,6 @@ export function handleOAuthResponse(sdk: OktaAuth, tokenParams: TokenParams, res
       if (accessToken) {
         var accessJwt = sdk.token.decode(accessToken);
         tokenDict.accessToken = {
-          value: accessToken, 
           accessToken: accessToken,
           claims: accessJwt.payload,
           expiresAt: Number(expiresIn) + Math.floor(Date.now() / 1000),
@@ -98,7 +97,6 @@ export function handleOAuthResponse(sdk: OktaAuth, tokenParams: TokenParams, res
 
       if (refreshToken) {
         tokenDict.refreshToken = {
-          value: refreshToken, 
           refreshToken: refreshToken,
           expiresAt: Number(expiresIn) + Math.floor(Date.now() / 1000),
           scopes: scopes,
@@ -112,7 +110,6 @@ export function handleOAuthResponse(sdk: OktaAuth, tokenParams: TokenParams, res
         var idJwt = sdk.token.decode(idToken);
 
         var idTokenObj: IDToken = {
-          value: idToken,
           idToken: idToken,
           claims: idJwt.payload,
           expiresAt: idJwt.payload.exp,

diff --git a/lib/types/Token.ts b/lib/types/Token.ts
@@ -14,7 +14,6 @@ import { UserClaims } from './UserClaims';
 
 export interface AbstractToken {
   expiresAt: number;
-  value: string;
   authorizeUrl: string;
   scopes: string[];
 }

diff --git a/test/support/oauthUtil.js b/test/support/oauthUtil.js
@@ -117,7 +117,6 @@ function validateResponse(res, expectedResp) {
       expect(actual).toEqual(expected);
       return;
     }
-    expect(actual.value).toEqual(expected.value);
     expect(actual.idToken).toEqual(expected.idToken);
     expect(actual.claims).toEqual(expected.claims);
     expect(actual.accessToken).toEqual(expected.accessToken);

diff --git a/test/support/tokens.js b/test/support/tokens.js
@@ -62,7 +62,6 @@ tokens.standardIdTokenClaims = {
 };
 
 tokens.standardIdTokenParsed = {
-  value: tokens.standardIdToken,
   idToken: tokens.standardIdToken,
   claims: tokens.standardIdTokenClaims,
   expiresAt: 1449699930,
@@ -108,7 +107,6 @@ tokens.standardIdToken2Claims = {
 };
 
 tokens.standardIdToken2Parsed = {
-  value: tokens.standardIdToken2,
   idToken: tokens.standardIdToken2,
   claims: tokens.standardIdToken2Claims,
   expiresAt: 1449699930,
@@ -153,7 +151,6 @@ tokens.expiredBeforeIssuedIdTokenClaims = {
 };
 
 tokens.expiredBeforeIssuedIdTokenParsed = {
-  value: tokens.expiredBeforeIssuedIdToken,
   idToken: tokens.expiredBeforeIssuedIdToken,
   claims: tokens.expiredBeforeIssuedIdTokenClaims,
   expiresAt: 1449690000,
@@ -191,7 +188,6 @@ tokens.authServerIdTokenClaims = {
 };
 
 tokens.authServerIdTokenParsed = {
-  value: tokens.authServerIdToken,
   idToken: tokens.authServerIdToken,
   claims: tokens.authServerIdTokenClaims,
   expiresAt: 1449699930,
@@ -266,7 +262,6 @@ tokens.standardAccessTokenClaims = {
 };
 
 tokens.standardAccessTokenParsed = {
-  value: tokens.standardAccessToken,
   accessToken: tokens.standardAccessToken,
   claims: tokens.standardAccessTokenClaims,
   expiresAt: 1449703529, // assuming time = 1449699929
@@ -306,7 +301,6 @@ tokens.authServerAccessTokenClaims = {
 };
 
 tokens.authServerAccessTokenParsed = {
-  value: tokens.authServerAccessToken,
   accessToken: tokens.authServerAccessToken,
   claims: tokens.authServerAccessTokenClaims,
   expiresAt: 1449703529, // assuming time = 1449699929